Merge remaining links from the apollo-link repo
#6577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwillson
force-pushed
the
merge-remaining-links
branch
from
b789ab5
to
d802720
Compare
hwillson
force-pushed
the
merge-remaining-links
branch
from
d802720
to
b194a6c
Compare
benjamn
approved these changes
Jul 13, 2020
There was a problem hiding this comment.
Looks great overall!
I noticed that functions like validateOperation from the utils directory are included in every CJS bundle, but I guess there's no way around that, since we can't actually import from packages like @apollo/client/link/utils within these implementations. And the ESM modules are not bundled, so there's no duplication if you're using an ESM-aware bundler.
benjamn
added a commit
that referenced
this pull request
Jul 13, 2020
hwillson
force-pushed
the
merge-remaining-links
branch
from
b5bdf73
to
f0c95c7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the remaining
apollo-linklinks into Apollo Client, giving each of them their own bundle/entry point:apollo-link-batchis now accessible via@apollo/client/link/batchapollo-link-batch-httpis now accessible via@apollo/client/link/batch-httpapollo-link-contextis now accessible via@apollo/client/link/contextapollo-link-erroris now accessible via@apollo/client/link/errorapollo-link-retryis now accessible via@apollo/client/link/retryapollo-link-schemais now accessible via@apollo/client/link/schemaapollo-link-wsis now accessible via@apollo/client/link/wsWe were previously planning on leaving these links in the
apollo-linkrepo, and publishing them with new@apollo/link-Xnaming. We have since decided that there is more value in managing these links as part of the Apollo Client project, to help streamline library maintenance, and pave the way for tighter / more efficient Apollo Client interactions.A quick note for reviewers (@benjamn @jcreighton): I've migrated the code as is (updating whatever needed updating to get the tests to pass), so you might want to skip over the link code / tests. 044db31 and f5dba6e are the main commits to review. Thanks!