Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

@apollo/client integration #1158

Closed
wants to merge 31 commits into from
Closed

@apollo/client integration #1158

wants to merge 31 commits into from

Conversation

hwillson
Copy link
Member

@hwillson hwillson commented Oct 3, 2019

Core Apollo Link functionality is being merged into Apollo Client 3. This PR removes the functionality that is going to be part of Apollo Client 3, and updates the remaining packages to include the common functionality they need from @apollo/client.

Related:

@hwillson
Copy link
Member Author

hwillson commented Oct 3, 2019

Note - tests here will fail until @apollo/client@3.0.0-alpha.7 is published.

@kamilkisiela
Copy link
Contributor

Could we merge apollographql/apollo-client#5541 and use @apollo/client/common? Otherwise apollo-link and every apollo-link-* package will break UI integrations other than React.

@codecov-io
Copy link

codecov-io commented Nov 15, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@482fb3e). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1158   +/-   ##
=========================================
  Coverage          ?   95.46%           
=========================================
  Files             ?       12           
  Lines             ?      353           
  Branches          ?       87           
=========================================
  Hits              ?      337           
  Misses            ?       16           
  Partials          ?        0
Impacted Files Coverage Δ
...ckages/apollo-link-batch-http/src/batchHttpLink.ts 90.62% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 482fb3e...faf1193. Read the comment docs.

Removes:

- apollo-link
- apollo-link-http-common
- apollo-link-http
@apollo/client is now a dependency of all Apollo Link packages.
This commit adjusts the remaining Apollo Link packages to
leverage the common link code now bundled into @apollo/client.
These are only be used by this test, so we'll create a copy of
them here to stop re-exporting them from `@apollo/client`.
Link deduplication now happens automatically in Apollo Client.
(which isn't available yet but will be soon)
 - apollo-link-batch-http@2.0.0-beta.0
 - apollo-link-batch@2.0.0-beta.0
 - apollo-link-context@2.0.0-beta.0
 - apollo-link-error@2.0.0-beta.0
 - apollo-link-polling@2.0.0-beta.0
 - apollo-link-retry@3.0.0-beta.0
 - apollo-link-schema@2.0.0-beta.0
 - apollo-link-ws@2.0.0-beta.0
 - zen-observable-ts@1.0.0-beta.0
@hwillson
Copy link
Member Author

hwillson commented Nov 15, 2019

The following beta Links are now published and ready for testing:

  • apollo-link-batch-http@2.0.0-beta.0
  • apollo-link-batch@2.0.0-beta.0
  • apollo-link-context@2.0.0-beta.0
  • apollo-link-error@2.0.0-beta.0
  • apollo-link-retry@3.0.0-beta.0
  • apollo-link-schema@2.0.0-beta.0
  • apollo-link-ws@2.0.0-beta.0

These have a dependency on @apollo/client@beta. Note that the docs will continue to fail here until we remove the Netlify job completely (which will happen when @apollo/client is launched).

 - @apollo/link-batch-http@2.0.0-beta.2
 - @apollo/link-batch@2.0.0-beta.2
 - @apollo/link-context@2.0.0-beta.2
 - @apollo/link-error@2.0.0-beta.2
 - @apollo/link-polling@2.0.0-beta.2
 - @apollo/link-retry@2.0.0-beta.2
 - @apollo/link-schema@2.0.0-beta.2
 - @apollo/link-ws@2.0.0-beta.2
 - zen-observable-ts@1.0.0-beta.2
 - @apollo/link-batch-http@2.0.0-beta.3
 - @apollo/link-batch@2.0.0-beta.3
 - @apollo/link-context@2.0.0-beta.3
 - @apollo/link-error@2.0.0-beta.3
 - @apollo/link-polling@2.0.0-beta.3
 - @apollo/link-retry@2.0.0-beta.3
 - @apollo/link-schema@2.0.0-beta.3
 - @apollo/link-ws@2.0.0-beta.3
@vvakame
Copy link

vvakame commented Jun 29, 2020

@hwillson could you publish with @apollo/client RC version?

@hwillson
Copy link
Member Author

We've decided to move the rest of the links in this repo over to the Apollo Client repo (details: apollographql/apollo-client#6577).

@hwillson hwillson closed this Jul 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants