Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow SchemaLink.Options.context function to be async. #6735

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Allow SchemaLink.Options.context function to be async. #6735

merged 1 commit into from
Jul 29, 2020

Conversation

benjamn
Copy link
Member

@benjamn benjamn commented Jul 29, 2020 •
edited
Loading

Closes #6730.

I chose to use the Promise API instead of async/await because async functions tend to grow large when compiled by TypeScript.

@benjamn benjamn added this to the Post 3.0 milestone Jul 29, 2020
@benjamn benjamn self-assigned this Jul 29, 2020
@benjamn benjamn mentioned this pull request Jul 29, 2020
Closed
hwillson
hwillson approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @benjamn - thanks!

@benjamn benjamn merged commit d7664b5 into master Jul 29, 2020
@benjamn benjamn deleted the async-schema-link-context-function branch July 29, 2020 18:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hwillson hwillson hwillson approved these changes

@jcreighton jcreighton Awaiting requested review from jcreighton

Assignees

@benjamn benjamn

Labels
🔗 apollo-link 🧞‍♂️ enhancement 🔠 quick-and-easy
Projects
None yet
Milestone
Post 3.0
Development

Successfully merging this pull request may close these issues.

context in SchemaLink is not async
2 participants
@benjamn @hwillson