Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable missing cache fields warning when using returnPartialData #7055

Merged
merged 2 commits into from
Sep 23, 2020

Conversation

hwillson
Copy link
Member

If returnPartialData is set to true for a query, disable the QueryManager Missing cache result fields warning, since developers have explicitly stated they want to work with partial data.

Fixes #7040

Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of 🥦  suggestions.

Not trying to make more work for you, by the way—let me know if you run out of time to keep working on this, and I'm happy to take over.

src/core/__tests__/QueryManager/index.ts Outdated Show resolved Hide resolved
src/core/__tests__/QueryManager/index.ts Show resolved Hide resolved
src/core/QueryManager.ts Show resolved Hide resolved
If `returnPartialData` is set to `true` for a query, disable
the `QueryManager` `Missing cache result fields` warning, since
developers have explicitly stated they want to work with partial
data.

Fixes #7040
@benjamn benjamn changed the base branch from release-3.3 to main September 23, 2020 15:03
@benjamn benjamn merged commit f53f71d into main Sep 23, 2020
@benjamn benjamn deleted the issue-7040 branch September 23, 2020 15:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

returnPartialData usage leads to "Missing cache result fields" warning
2 participants