Add older 'react-apollo' to transform imports #7216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
approved these changes
Oct 26, 2020
There was a problem hiding this comment.
Good catch @tm1000! This definitely makes as much sense as any of the other translations, as long as you remember to double-check the results of the transform (none of the translations are 100% perfect). Also, if I recall correctly, we designed this script so you can run it as many times as you like (it should be idempotent), so running it again after adding this new rule should work as expected.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply adds
react-apolloto the import.js for transformations. I'm not sure why it wasn't included, I added it to mine and transformed over 100+ js files and it worked fine