relayStylePagination honor pageInfo startCursor and endCursor #7224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
relayStylePagination
it's possible that the edges are not requested. In my specific case the api I'm integrating with incorrectly returns an empty list ofedges
in some cases.The
pageInfo
however does contain correctendCursor
andstartCursor
values.The problem with the way that
relayStylePagination
is implemented is that thestartCursor
andendCursor
will be overridden with an empty string""
instead of honoring thepageInfo
sent by the API.This change includes a test showing the problem (932bcfb) which fails with the state I am seeing:
The fix in 9ab6311 honors the
pageInfo
values.