Backport v3.4 Symbol.species fix for Concast and ObservableQuery. #7660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An attempt to address the problems I speculated about in #6520 (comment) Theory: in the Hermes JS engine, Symbol.species is not defined, so Object.defineProperty was not called, but perhaps "@@species" was getting set somewhere else by a polyfill library, causing the zen-observable library to fall back to "@@species" instead of using/ignoring the nonexistent Symbol.species symbol.
benjamn
commented
Feb 5, 2021
Comment on lines
+11
to
+13
| export function fixObservableSubclass< | ||
| S extends new (...args: any[]) => Observable<any>, | ||
| >(subclass: S): S { |
There was a problem hiding this comment.
This was the best way I could find to express that subclass should be a constructor function that creates a subtype of Observable.
jcreighton
approved these changes
Feb 5, 2021
This was referenced Mar 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I landed #7403 on the
release-3.4branch instead ofmainbecause I wasn't sure at the time if it would help fix the problem I described in #6520 (comment). Since then, multiple folks have commented that it did help, so I think it makes sense to backport this change tomain(3.3.x).While I was at it, I applied the same logic to
ObservableQuery(the otherObservablesubclass that Apollo Client uses), and added some regression tests of theSymbol.specieslogic for bothConcastandObservableQuery.