Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport v3.4 Symbol.species fix for Concast and ObservableQuery. #7660

Merged
merged 7 commits into from
Feb 5, 2021
Merged

Backport v3.4 Symbol.species fix for Concast and ObservableQuery. #7660

merged 7 commits into from
Feb 5, 2021

Commits on Feb 5, 2021

  1. Set both Symbol.species and "@@species" on Concast constructor (#7403) 

    An attempt to address the problems I speculated about in
#6520 (comment)

Theory: in the Hermes JS engine, Symbol.species is not defined, so
Object.defineProperty was not called, but perhaps "@@species" was getting
set somewhere else by a polyfill library, causing the zen-observable
library to fall back to "@@species" instead of using/ignoring the
nonexistent Symbol.species symbol.
    @benjamn
    benjamn committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    ab6b60a View commit details
    Browse the repository at this point in the history

  2. Fix minor type error for private Concast#resolve function.

    @benjamn
    benjamn committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    6d7a8eb View commit details
    Browse the repository at this point in the history

  3. Extract fixObservableSubclass helper function.

    @benjamn
    benjamn committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    78d9074 View commit details
    Browse the repository at this point in the history

  4. Allow Concast<T> constructor to be invoked with a Subscriber<T>.

    @benjamn
    benjamn committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    f1f9248 View commit details
    Browse the repository at this point in the history

  5. Use fixObservableSubclass for ObservableQuery, too.

    @benjamn
    benjamn committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    1b89257 View commit details
    Browse the repository at this point in the history

  6. Increase bundlesize limit from 25.5kB to 25.6kB.

    @benjamn
    benjamn committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    7648cf6 View commit details
    Browse the repository at this point in the history

  7. Mention PRs #7403 and #7660 in CHANGELOG.md.

    @benjamn
    benjamn committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    fc57af8 View commit details
    Browse the repository at this point in the history