-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow keyFields and keyArgs functions to return false #7900
Conversation
@CarsonF: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
Dang I thought this could be a quick fix. All I know is keyArgs: () => [] results in But keyArgs: () => false results in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thought, if you could look into those test failures, that'd be great. I'm also happy to jump in if you run out of time.
Thanks @benjamn! It would be lovely if you could jump in. I didn't study the implementation and am only ignoring the type errors in my codebase. |
Previously these functions were not allowed to return false even though false is supported.
Beautiful! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for getting this started @CarsonF!
Previously the function was not allowed to return false even though false is supported