Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow keyFields and keyArgs functions to return false #7900

Merged
merged 4 commits into from
Mar 25, 2021
Merged

Allow keyFields and keyArgs functions to return false #7900

merged 4 commits into from
Mar 25, 2021

Commits on Mar 25, 2021

  1. Allow keyFields and keyArgs functions to return false. 

    Previously these functions were not allowed to return false even though
false is supported.
    @CarsonF @benjamn
    CarsonF authored and benjamn committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    33f34e8 View commit details
    Browse the repository at this point in the history

  2. Fix some TypeScript errors for key{Fields,Args} return values.

    @benjamn
    benjamn committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    e23589e View commit details
    Browse the repository at this point in the history

  3. Add a test of keyFields and keyArgs functions returning false.

    @benjamn
    benjamn committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    dd367d7 View commit details
    Browse the repository at this point in the history

  4. Mention PR apollographql#7900 in CHANGELOG.md.

    @benjamn
    benjamn committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    2dc4560 View commit details
    Browse the repository at this point in the history