Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix webpack module resolution by renaming graphql.ts module #8862

Merged
merged 2 commits into from
Sep 29, 2021

Commits on Sep 28, 2021

  1. Attempt to fix webpack module resolution by renaming graphql.ts module.

    May fix #8861, if my hunch is correct that webpack is resolving the
    ```ts
    import { isType } from 'graphql'
    ```
    as importing from `utilities/globals/graphql.ts` module itself, rather
    than the `graphql` package, as suggested by the "(possible exports:
    removeTemporaryGlobals)" part of the error message:
    ```
    WARNING in ./node_modules/@apollo/client/utilities/globals/graphql.js 4:4-10
    export 'isType' (imported as 'isType') was not found in 'graphql' (possible exports: removeTemporaryGlobals)
    ```
    The only relevant module that exports `removeTemporaryGlobals` is
    `utilities/globals/graphql.ts`, so renaming that module to something
    that cannot be confused with the `graphql` package should either fix the
    problem or at least shed more light on what's going on.
    benjamn committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    434a41f View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2021

  1. Mention PR #8862 in CHANGELOG.md.

    benjamn committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    26bb607 View commit details
    Browse the repository at this point in the history