Fix build config to work on Windows #9805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanwulf
force-pushed
the
fix-windows-build
branch
from
2489b58
to
8ef4bc3
Compare
benjamn
approved these changes
Jun 10, 2022
There was a problem hiding this comment.
This makes sense to me, though I admit I have not run it myself on Windows. Thanks for keeping an eye on this @dylanwulf!
benjamn
added
🛠 tooling
and removed
🏓 awaiting-team-response
benjamn
force-pushed
the
fix-windows-build
branch
from
c677068
to
9f76033
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the build config to work on Windows.
The changes to
rollup.config.jsresulted from this discussion (almost a year ago!): #8341 (comment)The changes to
helpers.tsandrewriteSourceMaps.tswere needed because theglobpackage no longer supports backslashes as path separators in v8.0: https://github.com/isaacs/node-glob/blob/main/changelog.md#80