Update rollup to version 2.50.5

[benjamn]

It appears our closing of this old @renovate PR to update Rollup to v2 caused @renovate to stop opening PRs to update Rollup to any v2.x.y version, so our version of Rollup has been out of date since then.

Though obviously not ideal, this major version lag hasn't been a problem for us because Rollup v1 still works very well, and we use it only to generate CommonJS bundles, which is a relatively stable build target (CommonJS hasn't changed much lately). We rely on other tools like tsc for critical stuff like TypeScript compilation, and we have numerous ways to verify the output of our build system. With that said, Rollup v2 has some great new features that I'm looking forward to trying, such as output.inlineDynamicImports!

To verify these changes, I compared the output of the build system before and after this upgrade (taking f76ec87 and 2ae6ddd as given/prior):

diff --git a/@apollo/client/apollo-client.cjs.js b/@apollo/client/apollo-client.cjs.js
index 65e3dc0..16a05c0 100644
--- a/@apollo/client/apollo-client.cjs.js
+++ b/@apollo/client/apollo-client.cjs.js
@@ -4,13 +4,13 @@ Object.defineProperty(exports, '__esModule', { value: true });
 
 var tslib = require('tslib');
 var tsInvariant = require('ts-invariant');
-var graphql = require('graphql');
+var equality = require('@wry/equality');
 var zenObservableTs = require('zen-observable-ts');
 require('symbol-observable');
-var equality = require('@wry/equality');
+var graphql = require('graphql');
 var optimism = require('optimism');
-var trie = require('@wry/trie');
 var context = require('@wry/context');
+var trie = require('@wry/trie');
 var graphqlTag = require('graphql-tag');
 
 function shouldInclude(_a, variables) {
@@ -681,7 +681,7 @@ function isNonNullObject(obj) {
     return obj !== null && typeof obj === 'object';
 }
 
-var hasOwnProperty = Object.prototype.hasOwnProperty;
+var hasOwnProperty$2 = Object.prototype.hasOwnProperty;
 function mergeDeep() {
     var sources = [];
     for (var _i = 0; _i < arguments.length; _i++) {
@@ -718,7 +718,7 @@ var DeepMerger = (function () {
         }
         if (isNonNullObject(source) && isNonNullObject(target)) {
             Object.keys(source).forEach(function (sourceKey) {
-                if (hasOwnProperty.call(target, sourceKey)) {
+                if (hasOwnProperty$2.call(target, sourceKey)) {
                     var targetValue = target[sourceKey];
                     if (source[sourceKey] !== targetValue) {
                         var result = _this.reconciler.apply(_this, tslib.__spreadArrays([target, source, sourceKey], context));
@@ -1588,6 +1588,7 @@ var ApolloCache = (function () {
     return ApolloCache;
 }());
 
+exports.Cache = void 0;
 (function (Cache) {
 })(exports.Cache || (exports.Cache = {}));
 
@@ -3548,6 +3549,7 @@ var ApolloError = (function (_super) {
     return ApolloError;
 }(Error));
 
+exports.NetworkStatus = void 0;
 (function (NetworkStatus) {
     NetworkStatus[NetworkStatus["loading"] = 1] = "loading";
     NetworkStatus[NetworkStatus["setVariables"] = 2] = "setVariables";
@@ -4519,7 +4521,7 @@ function shouldWriteResult(result, errorPolicy) {
     return writeWithErrors;
 }
 
-var hasOwnProperty$2 = Object.prototype.hasOwnProperty;
+var hasOwnProperty = Object.prototype.hasOwnProperty;
 var QueryManager = (function () {
     function QueryManager(_a) {
         var cache = _a.cache, link = _a.link, _b = _a.queryDeduplication, queryDeduplication = _b === void 0 ? false : _b, onBroadcast = _a.onBroadcast, _c = _a.ssrMode, ssrMode = _c === void 0 ? false : _c, _d = _a.clientAwareness, clientAwareness = _d === void 0 ? {} : _d, localState = _a.localState, assumeImmutableResults = _a.assumeImmutableResults;
@@ -4670,7 +4672,7 @@ var QueryManager = (function () {
                 this.queries.forEach(function (_a, queryId) {
                     var observableQuery = _a.observableQuery;
                     var queryName = observableQuery && observableQuery.queryName;
-                    if (!queryName || !hasOwnProperty$2.call(updateQueries_1, queryName)) {
+                    if (!queryName || !hasOwnProperty.call(updateQueries_1, queryName)) {
                         return;
                     }
                     var updater = updateQueries_1[queryName];

All of these changes seem harmless/fine/good to me!

[hwillson]

Thanks for catching and fixing this @benjamn! (and sorry for inadvertently causing renovate to skip all of 2.x 😳)