Skip to content
This repository has been archived by the owner on Aug 20, 2020. It is now read-only.

UMD support #9

Merged
merged 1 commit into from
Jul 27, 2017
Merged

UMD support #9

merged 1 commit into from
Jul 27, 2017

Conversation

kamilkisiela
Copy link
Contributor

Fixes #3

Use /src as the root directory. No more /dist/src/index.js, just /dist/index.js.
Create /dist/bundle.umd.js
Use module, jsnext:main for /dist/index.js
Use main for /dist/bundle.umd.js

Fix shadow variable apolloFetch in /src/apollo-fetch.ts

@jbaxleyiii
Copy link
Contributor

@kamilkisiela thank you! @evanshauser this looks great to me! I don't want it to conflict with your learna work though, do you want me to merge this or wait and let you handle it?

@evans
Copy link
Contributor

evans commented Jul 26, 2017

@kamilkisiela Thank you so much for adding umd support! The repo is now converted over to lerna. I wasn't sure what the transition would look like, and now it seems that your changes would be almost drop into the apollo-fetch package! Could you rebase when you get a chance? Then I'll merge the changes in

Fixes #3

Use /src as the root directory. No more /dist/src/index.js, just /dist/index.js.
Create /dist/bundle.umd.js
Use `module`, `jsnext:main` for /dist/index.js
Use `main` for `/dist/bundle.umd.js

Fix shadow variable apolloFetch in src/apollo-fetch.ts
@kamilkisiela
Copy link
Contributor Author

@evanshauser @jbaxleyiii done

@evans evans merged commit 30486f7 into master Jul 27, 2017
@evans evans deleted the umd branch July 27, 2017 21:39
@evans
Copy link
Contributor

evans commented Jul 27, 2017

@kamilkisiela Great work, thank you for adding UMD support!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants