Skip to content

Commit

Permalink
fix: Remove debug print statements for websocket status (#253)
Browse files Browse the repository at this point in the history
  • Loading branch information
calvincestari committed Feb 2, 2024
1 parent 7cc5f48 commit 483b7e4
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 16 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/ci-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
- '.tuist-version'
tuist-generation:
runs-on: macos-14
runs-on: macos-13
needs: [changes]
if: ${{ needs.changes.outputs.ios == 'true' || needs.changes.outputs.codegen == 'true' || needs.changes.outputs.pagination == 'true' || needs.changes.outputs.tuist == 'true' }}
timeout-minutes: 8
Expand All @@ -64,7 +64,7 @@ jobs:
key: ${{ github.run_id }}-dependencies

run-swift-builds:
runs-on: macos-14
runs-on: macos-13
timeout-minutes: 15
strategy:
fail-fast: false
Expand All @@ -86,7 +86,7 @@ jobs:
cd ${{ matrix.package }} && swift build
build-and-unit-test:
runs-on: macos-14
runs-on: macos-13
needs: [tuist-generation, changes]
timeout-minutes: 20
strategy:
Expand Down Expand Up @@ -190,7 +190,7 @@ jobs:
TestResults/ResultBundle.zip
run-codegen-test-configurations:
runs-on: macos-14
runs-on: macos-13
timeout-minutes: 20
name: Codegen Test Configurations - macOS
steps:
Expand All @@ -209,7 +209,7 @@ jobs:
./scripts/run-test-codegen-configurations.sh -t
verify-frontend-bundle-latest:
runs-on: macos-14
runs-on: macos-13
needs: [changes]
if: ${{ needs.changes.outputs.codegen == 'true' }}
timeout-minutes: 5
Expand All @@ -227,7 +227,7 @@ jobs:
git diff --exit-code
run-cocoapods-integration-tests:
runs-on: macos-14
runs-on: macos-13
timeout-minutes: 20
name: Cocoapods Integration Tests - macOS
steps:
Expand All @@ -247,7 +247,7 @@ jobs:
uses: ./.github/actions/run-cocoapods-integration-tests

run-integration-tests:
runs-on: macos-14
runs-on: macos-13
needs: [tuist-generation, changes]
if: ${{ needs.changes.outputs.ios == 'true' }}
timeout-minutes: 20
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-subtree-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ on:
jobs:
split-subtrees:
if: ${{ github.event.pull_request.merged }}
runs-on: macos-14
runs-on: macos-13
name: Split and Push Subtrees
steps:
- name: Checkout Repo
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/release-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ env:

jobs:
tuist-generation:
runs-on: macos-14
runs-on: macos-13
timeout-minutes: 8
name: Run Tuist Generation
steps:
Expand All @@ -31,7 +31,7 @@ jobs:
key: ${{ github.run_id }}-dependencies

run-swift-builds:
runs-on: macos-14
runs-on: macos-13
timeout-minutes: 15
strategy:
fail-fast: false
Expand All @@ -53,7 +53,7 @@ jobs:
cd ${{ matrix.package }} && swift build
build-and-unit-test:
runs-on: macos-14
runs-on: macos-13
needs: tuist-generation
timeout-minutes: 20
strategy:
Expand Down Expand Up @@ -218,7 +218,7 @@ jobs:
# TestResults/ResultBundle.zip

run-codegen-test-configurations:
runs-on: macos-14
runs-on: macos-13
timeout-minutes: 20
name: Codegen Test Configurations - macOS
steps:
Expand All @@ -237,7 +237,7 @@ jobs:
./scripts/run-test-codegen-configurations.sh -t
run-cocoapods-integration-tests:
runs-on: macos-14
runs-on: macos-13
timeout-minutes: 20
name: Cocoapods Integration Tests - macOS
steps:
Expand All @@ -257,7 +257,7 @@ jobs:
uses: ./.github/actions/run-cocoapods-integration-tests

run-integration-tests:
runs-on: macos-14
runs-on: macos-13
needs: tuist-generation
timeout-minutes: 20
name: Apollo Integration Tests - macOS
Expand Down
3 changes: 1 addition & 2 deletions apollo-ios/Sources/ApolloWebSocket/WebSocketTransport.swift
Original file line number Diff line number Diff line change
Expand Up @@ -528,11 +528,10 @@ extension WebSocketTransport: WebSocketClientDelegate {
public func websocketDidDisconnect(socket: WebSocketClient, error: Error?) {
self.$socketConnectionState.mutate { $0 = .disconnected }
if let error = error {
debugPrint("websocket is disconnected: \(error)")
handleDisconnection(with: error)

} else {
self.$error.mutate { $0 = nil }
debugPrint("websocket is disconnected")
self.handleDisconnection()
}
}
Expand Down

0 comments on commit 483b7e4

Please sign in to comment.