Remove debug print statements for websocket status #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
BobaFetters
approved these changes
Feb 1, 2024
calvincestari
force-pushed
the
remove-debug-print
branch
from
cb2bf4a
to
aa3b6fb
Compare
calvincestari
force-pushed
the
remove-debug-print
branch
from
aa3b6fb
to
a247989
Compare
calvincestari
force-pushed
the
remove-debug-print
branch
from
73a58d1
to
1debfc6
Compare
BobaFetters
pushed a commit
that referenced
this pull request
Feb 2, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios
that referenced
this pull request
Feb 2, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apollographql/apollo-ios#3325.
This removes the two
debugPrintstatements from websocket disconnection status changes. There really is no point to them sincedebugPrintonly writes to stdout and in both cases the disconnection is sent to the delegate's handler or all websocket watchers.There is another
debugPrintstatement being called in theDispatchQueueextension but I'm not really sure how we should handle that one. My first thought was to change it to apreconditionFailurewhich would alert users that there is an error flow not being handled but the standard Release build (-0) will crash their app which is a breaking change. That function also doesn't throw so there really is nothing to be done other than swallowing the error; maybe we should just leave that one alone for now since at least there will be log message being printed somewhere?