Add support for multiple headers #1153
Conversation
|
@LachlanMcCulloch: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
| <FileRef | ||
| location = "self:"> | ||
| </FileRef> | ||
| </Workspace> |
There was a problem hiding this comment.
I don't believe this needs to be committed
There was a problem hiding this comment.
Have removed - I'm unfamiliar with SPM 😅
| @@ -54,7 +57,8 @@ class ApolloSchemaTests: XCTestCase { | |||
| "--endpoint=http://localhost:8080/graphql", | |||
| "--key=\(apiKey)", | |||
| "'\(expectedOutputURL.path)'", | |||
| "--header='\(header)'" | |||
| "--header='\(headers.first!)'", | |||
| "--header='\(headers.last!)'" | |||
There was a problem hiding this comment.
I'd prefer these not have force-unwraps - maybe declare it as two vars and then shove those into the header array. However, this is something I can fix post-merge if you prefer.
There was a problem hiding this comment.
Too easy - have created two separate variables labelled firstHeader and lastHeader for clarity and to remove the force unwraps
| @@ -4,6 +4,6 @@ import XCTest | |||
| class VersionNumberTests: XCTestCase { | |||
| func testVersionNumberExists() { | |||
| // It would be the first 2 digits of version number like `0.19`. | |||
| XCTAssertGreaterThanOrEqual(ApolloVersionNumber, 0) | |||
| // XCTAssertGreaterThanOrEqual(ApolloVersionNumber, 0) | |||
There was a problem hiding this comment.
This should not be committed - I know it doesn't run right if you're not using the schemes, but I'd still prefer to run it with the schemes.
There was a problem hiding this comment.
Yep, this was my bad, I meant to uncomment and should be back to normal now
No description provided.