Better thread safety through NSLocking #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…prevent bad access from other threads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #1181. Noticed as I was investigating a bunch of
EXC_BAD_ACCESScrashes that I was making some pretty silly assumptions about multithreading, particularly when it came to when calls are being set up. Multiple threads trying to access the same thing at the same time is a huge recipe forEXC_BAD_ACCESS, so that seemed like a reasonable place to start.Wrapped the dictionaries underlying
URLSessionClientin ourAtomicgeneric wrapper, which usesNSLockto enforce one-thread-at-a-time access. Initial feedback on this fixing the crash seems promising.This isn't exactly an iOS Meme....
...but it's close.