Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds disallowed names to schema namespace validation #2755

Merged
merged 2 commits into from
Jan 6, 2023
Merged

Adds disallowed names to schema namespace validation #2755

merged 2 commits into from
Jan 6, 2023

Conversation

calvincestari
Copy link
Member

Fixes #2664

  • Repurposes the schemaNameConflict error to be more a more general purpose type collision error
  • Adds logic to validate the given schema namespace name against a new list of disallowed names

@netlify
Copy link

netlify bot commented Jan 5, 2023 •
edited
Loading

✅ Deploy Preview for apollo-ios-docs canceled.

Name Link
🔨 Latest commit 588a773
🔍 Latest deploy log https://app.netlify.com/sites/apollo-ios-docs/deploys/63b86aea086863000876b869

AnthonyMDev
AnthonyMDev approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@AnthonyMDev AnthonyMDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you!

@AnthonyMDev
Copy link
Contributor

Are there any other obvious Schema names we want to disallow? I don't think any others should be problematic off the top of my head?

Actually Fragments may or may not be? Kinda an odd name to use, but I think it would cause the same compilation error possibly?

@calvincestari calvincestari merged commit 97b70d1 into main Jan 6, 2023
@calvincestari calvincestari deleted the fix/disallow-schemaname-schema branch January 6, 2023 18:48
@calvincestari calvincestari mentioned this pull request Jan 10, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnthonyMDev AnthonyMDev AnthonyMDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Namespace collision when using Schema for schemaName
2 participants
@calvincestari @AnthonyMDev