Expose HTTPNetworkDelegate publicly as weak var #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…after initialization
|
@designatednerd as this is silently breaking change I think you should remove delegate from init so people would realise that something is changed and double check that they retain delegate |
|
🤔Hmm - let me think on that, but interesting suggestion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had a good discussion in Spectrum about why this was set as an internal
letrather than apublic weak var, which would allow the delegate to be set after initialization.Having dug back through the history of the code, there really wasn't a good reason not to do it that way, so I've gone ahead and made the change.
This is a potentially breaking change - in theory switching this to a
weak varmostly helps prevent retain cycles, but if you weren't holding on to the delegate already, this could theoretically result in the delegate getting autoreleased in places it wasn't before.