Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Speed up build configuration time #1451

Merged
merged 3 commits into from Jul 24, 2019
Merged

Fix: Speed up build configuration time #1451

merged 3 commits into from Jul 24, 2019

Commits on Jul 22, 2019

  1. Fix: Speed up build configuration time by lazily verifying apollo-cod… 

    …egen installation

Move Apollo global verification to the beginning of the task to speed up configuration process.

Before, this I/O operation (version check) would run in configuration time and take up to 5sec. This runs in every Gradle execution (even when unrelated to Apollo)

This commit fixes apollographql#1203 and moves verification to a later stage.

This means that we cannot easily fall-back to local installation that easily. That's why an exception is thrown with an appropriate message. User should disable using this feature if they don't have global installation.
    @tasomaniac
    tasomaniac committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    6310293 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2019

  1. Replace println with info logs

    @tasomaniac
    tasomaniac committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    b5eb9ba View commit details
    Browse the repository at this point in the history

  2. Move verification into exec. doFirst does not really run first

    @tasomaniac
    tasomaniac committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    29aa035 View commit details
    Browse the repository at this point in the history