chore: fix CI

[JoviDeCroock]

This is a temp placeholder, so I can see what holds the CI up in our webview.

Caching etc seems covered now, could someone double check if there's any regression in things covered by the CI, I think not but yes I'm not that experienced with this repo yet.

[codecov-io]

Codecov Report

Merging #919 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #919   +/-   ##
=======================================
  Coverage   96.37%   96.37%           
=======================================
  Files          20       20           
  Lines         662      662           
  Branches      163      167    +4     
=======================================
  Hits          638      638           
  Misses         19       19           
  Partials        5        5

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ef15fc...8648585. Read the comment docs.

[JoviDeCroock]

Not mergeable yet, still an issue with the cache Error computing cache key: template: cacheKey:1:45: executing "cacheKey" at <checksum "package-ch...>: error calling checksum: open /home/circleci/project/package-checksum: no such file or directory

[JoviDeCroock]

I would also propose to reduce the filesize checks to more reasonable amounts:

 PASS  ./packages/apollo-link-batch/lib/bundle.min.js: 1.44KB < maxSize 1.5KB (gzip) 

 PASS  ./packages/apollo-link-batch-http/lib/bundle.min.js: 5.66KB < maxSize 6.8KB (gzip) 

 PASS  ./packages/apollo-link-dedup/lib/bundle.min.js: 956B < maxSize 3KB (gzip) 

 PASS  ./packages/apollo-link-error/lib/bundle.min.js: 895B < maxSize 1KB (gzip) 

 PASS  ./packages/apollo-link-http/lib/bundle.min.js: 5.13KB < maxSize 6KB (gzip) 

 PASS  ./packages/apollo-link-polling/lib/bundle.min.js: 790B < maxSize 1KB (gzip) 

 PASS  ./packages/apollo-link-retry/lib/bundle.min.js: 2.07KB < maxSize 2.5KB (gzip) 

 PASS  ./packages/apollo-link-ws/lib/bundle.min.js: 8.75KB < maxSize 10KB (gzip) ```

[JoviDeCroock]

Weird, the circleci is not starting again....

[hwillson]

I think it will @JoviDeCroock - it's just being delayed by other queued up and running tests (related to other projects).

[JoviDeCroock]

I think it will @JoviDeCroock - it's just being delayed by other queued up and running tests (related to other projects).

Allright, being too hasty :D was trying to debug the issue but not really finding the queue issue atm

[JoviDeCroock]

Shouldn't we add monorepo step as required aswell?

[hwillson]

Yes, for sure - I couldn't add it when I was adjusting the checks last time, because a successful build hadn't completed yet. I can (and will) add it now. Thanks!

[JoviDeCroock]

Allright, thank you for the help!

[hwillson]

This is awesome @JoviDeCroock! I've added one comment, but it's more for us internally. Thanks very much for your work on this!

[hwillson]

I know we're building the docs like this in other repos, but I have a feeling this isn't really necessary. Our Netlify based docs build and deploy process is already taking care of this, and if the docs fail to build for any reason, an error will be reported by the Netlify GitHub check. Let's leave this docs CI step for now, but food for future thought.