feat(compiler): validate variable definition uniqueness #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrlna
added
the
apollo-compiler
|
gonna close this and do all the variable validations (#312) all together in one PR (and not only because i don't want to deal with all these conflicts >.<) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trying out the new diagnostics changes from #414 !
@goto-bus-stop so far so good! process seems to be just as straightforward as before 🙏
I am now noticing the thing you pointed out this morning about fileids in diagnostics struct - basically all the tests get updated whenever you add a new file, which means there are a ton of diffs.