Make initialize method in data sources optional

apollographql · Jul 18, 2018 · c4d3a93 · c4d3a93
1 parent 4f7b6e0
commit c4d3a93
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/apollo-datasource/src/index.ts b/packages/apollo-datasource/src/index.ts
@@ -6,5 +6,5 @@ export interface DataSourceConfig<TContext> {
 }
 
 export abstract class DataSource<TContext = any> {
-  abstract initialize(config: DataSourceConfig<TContext>): void;
+  initialize?(config: DataSourceConfig<TContext>): void;
 }
diff --git a/packages/apollo-server-core/src/runHttpQuery.ts b/packages/apollo-server-core/src/runHttpQuery.ts
@@ -341,7 +341,9 @@ export async function runHttpQuery(
         const dataSources = optionsObject.dataSources() || {};
 
         for (const dataSource of Object.values(dataSources)) {
-          dataSource.initialize({ context, cache: optionsObject.cache! });
+          if (dataSource.initialize) {
+            dataSource.initialize({ context, cache: optionsObject.cache! });
+          }
         }
 
         if ('dataSources' in context) {