Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't load apollo-upload-server if uploads are disabled #1536

Closed
Akryum opened this issue Aug 15, 2018 · 4 comments
Closed

Shouldn't load apollo-upload-server if uploads are disabled #1536

Akryum opened this issue Aug 15, 2018 · 4 comments

Comments

@Akryum
Copy link

Akryum commented Aug 15, 2018

If uploads option is false on ApolloServer constructor options, the apollo-upload-server module is still loaded. On some node versions, this causes issues like core-js not being found.

This would help close vuejs/vue-cli#2215 (we don't need file uploads for vue cli ui).

@Akryum
Copy link
Author

Akryum commented Aug 15, 2018

I believe https://github.com/jaydenseric/apollo-upload-server/releases/tag/v6.0.0-alpha.1 would fix the issue but it's still in alpha.

@yofriadi
Copy link

#1542

@abernix
Copy link
Member

abernix commented Aug 21, 2018

@Akryum It does seem wise to avoid loading apollo-upload-server if uploads are disabled, but I think the overall issue with core-js has been fixed now, as explained in #1542 (comment).

Should we keep this open? (I think a PR that conditionally requires apollo-upload-server would be welcome, but it seems less urgent without the core-js issue at play.)

@martijnwalraven
Copy link
Contributor

I actually already did this as part of a PR for running Apollo Server on edge. I'll pick that work up later, but I've just merged those commits to get this in and avoid the PR from getting out of sync.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants