Have content type of application/vnd.api+json parsed as json in the RestDataSource library

[nholik]

It would be nice if responses using jsonapi where the content type is application/vnd.api+json would be parsed as JSON.

Right now anything with content type starting with 'application/json' or 'application/hal+json' as seen here:

apollo-server/packages/apollo-datasource-rest/src/RESTDataSource.ts

Line 119 in 0163a5f

(contentType.startsWith('application/json') ||

and here

apollo-server/packages/apollo-datasource-rest/src/RESTDataSource.ts

Line 120 in 0163a5f

contentType.startsWith('application/hal+json'))

is parsed in the library, and it would be nice to have application/vnd.api+json follow the same pattern.

Either adding this additional type or making a more general change to anything ending with '+json' seem like to viable approaches.

I do see here that one suggestion is overriding, but a more general approach may help avoid the question all together with checking for trailing '+json' and having the override option for more esoteric content types outside the two patterns.

I'd be happy to submit a PR if such a change could be accommodated.

[glasser]

Sure, file a PR. apollo-datasource-rest is not currently very actively maintained but a very simple PR should be fine.

[nholik]

Thanks @glasser submitted the change - pretty simple.