Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hapi v17 #636

Closed
flippidippi opened this issue Oct 24, 2017 · 10 comments · Fixed by #687
Closed

Hapi v17 #636

flippidippi opened this issue Oct 24, 2017 · 10 comments · Fixed by #687

Comments

@flippidippi
Copy link

Upgrade hapi plugin to work with new release of Hapi hapijs/hapi#3658
@martijnwalraven
Copy link
Contributor

A PR would be great!

@lobosan
Copy link

lobosan commented Oct 24, 2017

Yes please and also provide a simple boilerplate to get started and explain how to do authentication, acl, cookies and input validation. Thanks

@samueljoli
Copy link

Hey is this currently assigned to anyone?

@flippidippi
Copy link
Author

I haven’t had time recently so I’m not sure if anyone is working on this.

@daoanhnhat1995
Copy link

I can work on this today or tomorrow if nobody's been assigned

@martijnwalraven
Copy link
Contributor

@daoanhnhat1995 That would be great, it doesn't seem like anyone is working on it!

@daoanhnhat1995
Copy link

@martijnwalraven Hapi17 typings hasn't been updated yet so we'll have to wait till then?

@martijnwalraven
Copy link
Contributor

@daoanhnhat1995 It seems like it, or maybe they would accept a PR as well?

@SOULPWRD
Copy link

SOULPWRD commented Nov 28, 2017 •
edited

Hapi 17 typings are already in PR and been waiting just for a code review.

Any updates on this issue?
Thanks :)

@rafaelsouzaf
Copy link

@SOULPWRD It's in under development, really :-)

@ItalyPaleAle ItalyPaleAle mentioned this issue Dec 6, 2017
Merged
addityasingh added a commit to addityasingh/apollo-server that referenced this issue Oct 8, 2018
@addityasingh
feat: Update package lock apollographql#636
1ff69c7
addityasingh added a commit to addityasingh/apollo-server that referenced this issue Oct 11, 2018
@addityasingh
feat: Update package lock apollographql#636
d78d51a
addityasingh added a commit to addityasingh/apollo-server that referenced this issue Nov 13, 2018
@addityasingh
feat: Update tsconfig apollographql#636
c4a8b58
addityasingh added a commit to addityasingh/apollo-server that referenced this issue Nov 14, 2018
@addityasingh
feat: Remove overriding tsc compile command apollographql#636
2a74353
addityasingh added a commit to addityasingh/apollo-server that referenced this issue Nov 14, 2018
@addityasingh
feat: Add jest config apollographql#636
9d22b2f
addityasingh added a commit to addityasingh/apollo-server that referenced this issue Nov 14, 2018
@addityasingh
feat: Add tsconfig for fastify tests apollographql#636
2977562
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to Hapi 17 ItalyPaleAle/apollo-server
7 participants
@martijnwalraven @lobosan @flippidippi @rafaelsouzaf @daoanhnhat1995 @SOULPWRD @samueljoli