Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@apollo/utils.logger should be declared in the dependencies of apollo-server-types #6389

Closed
Grmiade opened this issue May 5, 2022 · 1 comment · Fixed by #6393
Closed

@apollo/utils.logger should be declared in the dependencies of apollo-server-types #6389

Grmiade opened this issue May 5, 2022 · 1 comment · Fixed by #6393

Comments

@Grmiade
Copy link

Grmiade commented May 5, 2022 •
edited
Loading

@apollo/utils.logger should be declared in the dependencies of apollo-server-types

Regression introduced by e09a94b#diff-c3e5296b7b2d40bf15864e047a623dbd664f236d2d12229967402a5c0324e0d6
@glasser
Copy link
Member

glasser commented May 5, 2022

Good catch. Will fix.

glasser added a commit that referenced this issue May 5, 2022
@glasser
Fix a bundle of dependency issues
32e34ab 
Some packages were depending on other packages that were only declared
as transitive dependencies. Clean this up by adding appropriate
dependencies (or in one case, just re-declaring ValueOrPromise and
dropping the apollo-server-types dependency).

The peer dep one is a bit funny.  But "Y has a peer dep on Z" means
"when you install Y you need to install Z", and so if X depends on Y,
then when you install X you need to install Z... so sure, that means X
needs to have a peer dep on Z too, I guess.

Fixes #6389.
Fixes #6390.
Fixes #6391.
Fixes #6392.
@glasser glasser mentioned this issue May 5, 2022
Merged
glasser added a commit that referenced this issue May 5, 2022
@glasser
Fix a bundle of dependency issues
e3c078e 
Some packages were depending on other packages that were only declared
as transitive dependencies. Clean this up by adding appropriate
dependencies (or in one case, just re-declaring ValueOrPromise and
dropping the apollo-server-types dependency).

The peer dep one is a bit funny.  But "Y has a peer dep on Z" means
"when you install Y you need to install Z", and so if X depends on Y,
then when you install X you need to install Z... so sure, that means X
needs to have a peer dep on Z too, I guess.

Fixes #6389.
Fixes #6390.
Fixes #6391.
Fixes #6392.
glasser added a commit that referenced this issue May 5, 2022
@glasser
Fix a bundle of dependency issues (#6393)
2706fc2 
Some packages were depending on other packages that were only declared
as transitive dependencies. Clean this up by adding appropriate
dependencies (or in one case, just re-declaring ValueOrPromise and
dropping the apollo-server-types dependency).

The peer dep one is a bit funny.  But "Y has a peer dep on Z" means
"when you install Y you need to install Z", and so if X depends on Y,
then when you install X you need to install Z... so sure, that means X
needs to have a peer dep on Z too, I guess.

Fixes #6389.
Fixes #6390.
Fixes #6391.
Fixes #6392.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix a bundle of dependency issues apollographql/apollo-server
2 participants
@glasser @Grmiade