consider moving expressMiddleware to a deep import #6587
Assignees
Milestone
Comments
glasser
added a commit
that referenced
this issue
Jun 24, 2022
While expressMiddleware has no runtime dependencies, it does rely on the specific API of Express 4. One of the nice things about Express is that its development had slowed and it was a very stable target, but all good things must come to an end: Express 5 may be coming soon expressjs/express#4920 (I kid: the changes in Express 5, like support for proper error handling with async functions, look great.) So let's preemptively put this under `/express4` so that if the Express 5 middleware needs to be a bit different (if nothing else, the req/res types in the context function may vary) that we'll have an obvious place to put it. Fixes #6587.
glasser
added a commit
that referenced
this issue
Jun 24, 2022
While expressMiddleware has no runtime dependencies, it does rely on the specific API of Express 4. One of the nice things about Express is that its development had slowed and it was a very stable target, but all good things must come to an end: Express 5 may be coming soon expressjs/express#4920 (I kid: the changes in Express 5, like support for proper error handling with async functions, look great.) So let's preemptively put this under `/express4` so that if the Express 5 middleware needs to be a bit different (if nothing else, the req/res types in the context function may vary) that we'll have an obvious place to put it. Fixes #6587.
|
Fixed on version-4 in #6612 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
@apollo/server/expressor even@apollo/server/express4.it doesn't have runtime dependencies but it especially might be nice to do the latter since express5 is imminent (sigh, the best thing about Express is that it hasn't been a moving target...)
The text was updated successfully, but these errors were encountered: