Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider false default for fieldLevelInstrumentation (version 4) #6708

Closed
trevor-scheer opened this issue Jul 21, 2022 · 5 comments
Closed
Milestone

Comments

@trevor-scheer
Copy link
Member

We should probably change the default for fieldLevelInstrumentation to return false instead of true, and I think @glasser agrees.

// We should strongly consider changing the default to false in AS4.

Since trace data could then be unexpectedly missing, we can log a warning which leads to some documentation. The docs should explain how to get rid of the warning (by configuring it?), explain the performance characteristics, and suggest sane values for production.

@trevor-scheer trevor-scheer added this to the Release 4.0 milestone Jul 21, 2022
@glasser
Copy link
Member

glasser commented Jul 21, 2022

Related: #6051

Doing that issue would not be quite as much as this, because having traces off but FLI on still gives you field execution statistics.

@glasser
Copy link
Member

glasser commented Jul 21, 2022

When we make this change, we should tweak the wording on studio-ui's FieldUsageStatBanner to not say that you have "disabled" this feature but just to say that it is not enabled.

@glasser
Copy link
Member

glasser commented Aug 26, 2022

In the interest of moving this project towards finished, let's leave the defaults for "send any traces?" and "instrument fields?" at turned on. The onboarding experience is better that way (ie, no changes needed to Studio UI) and if it's a performance problem you can tweak the settings (or move to Router if you're on Gateway!).

@glasser glasser closed this as completed Aug 26, 2022
@glasser glasser reopened this Aug 26, 2022
@glasser
Copy link
Member

glasser commented Aug 26, 2022

reopening until i delete that comment

@glasser
Copy link
Member

glasser commented Aug 26, 2022

Finished up in #6855.

@glasser glasser closed this as not planned Won't fix, can't repro, duplicate, stale Aug 26, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants