-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider false default for fieldLevelInstrumentation
(version 4)
#6708
Comments
Related: #6051 Doing that issue would not be quite as much as this, because having traces off but FLI on still gives you field execution statistics. |
When we make this change, we should tweak the wording on studio-ui's FieldUsageStatBanner to not say that you have "disabled" this feature but just to say that it is not enabled. |
In the interest of moving this project towards finished, let's leave the defaults for "send any traces?" and "instrument fields?" at turned on. The onboarding experience is better that way (ie, no changes needed to Studio UI) and if it's a performance problem you can tweak the settings (or move to Router if you're on Gateway!). |
reopening until i delete that comment |
Finished up in #6855. |
We should probably change the default for
fieldLevelInstrumentation
to return false instead of true, and I think @glasser agrees.apollo-server/packages/server/src/plugin/usageReporting/options.ts
Line 57 in db0dcaa
Since trace data could then be unexpectedly missing, we can log a warning which leads to some documentation. The docs should explain how to get rid of the warning (by configuring it?), explain the performance characteristics, and suggest sane values for production.
The text was updated successfully, but these errors were encountered: