Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[apollo-server-core] Optionally Skip Query Validation? #722

Closed
Piefayth opened this issue Dec 18, 2017 · 2 comments
Closed

[apollo-server-core] Optionally Skip Query Validation? #722

Piefayth opened this issue Dec 18, 2017 · 2 comments
Labels
⛲️ feature New addition or enhancement to existing solutions

Comments

@Piefayth
Copy link

Piefayth commented Dec 18, 2017

We want to cache the results of parse & validate for queries sent to our service. On subsequent requests, we would like to avoid re-validating the cached parsed query. This bit of code in runQuery always runs all the default validation rules, leaving us unable to leverage it on subsequent requests without doing an unnecessary revalidation. The comment above that code snippet describes our desired behavior, but the implementation itself seems to not.

Is there a way to circumvent this? If not, is this something that can be added or adjusted? Happy to submit a PR if needed. Thanks.

@Piefayth
Copy link
Author

Hi, hoping this can get some traction now that we're past the holiday. I noticed that this comment, as well, indicates different behavior than what is actually happening. Again, just let me know what you'd like to see in a PR for this one and I'll get it together. Thank you.

@martijnwalraven martijnwalraven added this to Needs triage in New request pipeline via automation Sep 27, 2018
@martijnwalraven martijnwalraven added ⛲️ feature New addition or enhancement to existing solutions and removed request pipeline labels Sep 27, 2018
@martijnwalraven martijnwalraven moved this from Needs triage to To do in New request pipeline Sep 27, 2018
@abernix
Copy link
Member

abernix commented Feb 4, 2019

This should be implemented by #2111. Please do try it out!

@abernix abernix closed this as completed Feb 4, 2019
New request pipeline automation moved this from To do to Done Feb 4, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⛲️ feature New addition or enhancement to existing solutions
Projects
No open projects
Development

No branches or pull requests

3 participants