Document that formatResponse also gets the query

[dandv]

No description provided.

[unicodeveloper]

Hey @dandv you didn't document that in this PR. Any reason why?

[martijnwalraven]

Note that the shape of that query parameter is likely to change in the next version, so I wouldn't consider this part of the public API yet.

[dandv]

@unicodeveloper: I was respecting the doc style and thought that the "per input" part of "per input, response, and errors" refers to the query, since the error or response parameters aren't explicitly documented either, except by way of example.

But in the light of what @martijnwalraven said, feel free to close the PR without merging.

[dandv]

Looks like that change has occurred, and the query object no longer has queryString and variables. What is the current recommended way to log these for every query? The docs are vague.

[dandv]

Ping? This change breaks logging queries.

[ghost]

Hi @dandv it was changed again, as a second param you will get request context:

apollo-server/packages/apollo-server-core/src/graphqlOptions.ts

Line 50 in 8059326

requestContext: GraphQLRequestContext<TContext>,

[dandv]

I've been using this with v2.9.15:

new ApolloServer({
  // ...
  context: async ({ req }) => {
    const request = req.method === 'GET' ? req.query : req.body;  // POST vs. GET
    if (!request.query.startsWith('query IntrospectionQuery'))
      logger.info(`GraphQL query&variables`, {
        query: request.query,
        vars: request.variables,  // TODO: how are variables passed via GET?
      });
  }
});