Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding sendVariableValues and sendHeaders parameters and specifications to engine #2847

Merged
merged 8 commits into from
Jun 26, 2019
Merged

Adding sendVariableValues and sendHeaders parameters and specifications to engine #2847

merged 8 commits into from
Jun 26, 2019

Commits on Jun 19, 2019

  1. - changed name of the new option (from enforcePrivateVariables to mas… 

    …kVariableValues), but this is still TBD

- use the same helper for both the deprecated privateVariable option and the new option, since the logic is (basically) the same
- added helper (and tests) to enforce that originalVariables.keys == modifiedVariables.keys
- updated documentation
    Helen Ho committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    1ebc472 View commit details
    Browse the repository at this point in the history

  2. Changed new option to sendVariableValues instead of maskVariableValue… 

    …s, and the subsequent tests/docs
    Helen Ho committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    862017e View commit details
    Browse the repository at this point in the history

  3. adding new reporting option sendHeaders, fixing some names

    Helen Ho committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    896c311 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2019

  1. addressing comments, name/argument changes, updating docs, adding and… 

    … fixing test cases
    Helen Ho committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    8f9bbaf View commit details
    Browse the repository at this point in the history

  2. adding another parameter for specifying safelisted variable names

    Helen Ho committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    09946ae View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2019

  1. more doc fixes, adding some checks for invalid inputs

    Helen Ho committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    cf1c21d View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2019

  1. changed suboption name, updating docs with more info on breaking change

    Helen Ho committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    db9c49f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into EnforcingPrivateVariables

    Helen committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    8636c3e View commit details
    Browse the repository at this point in the history