schema-reporting: Fix error message whitespace, add tests for overrideReportedSchema #4581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachindshinde
changed the title
sachindshinde
force-pushed
the
sachin/add-tests-for-overrideReportedSchema
branch
from
93c929a
to
f645699
Compare
glasser
approved these changes
Sep 22, 2020
|
Perhaps add a CHANGELOG entry for the error message typo? |
sachindshinde
deleted the
sachin/add-tests-for-overrideReportedSchema
branch
This was referenced Mar 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In accordance with the feedback here, this PR adds testing for
overrideReportedSchema. This PR also fixes a bug in the error message where a space was missing.