apollo-server-azure-functions: Health checks implementation #5003

vany0114 · 2021-03-07T21:23:52Z

This PR implements health checks for apollo-server-azure-functions package.
Issue: #4925

Note: I wasn't able to test this locally since I couldn't build the whole repo, however tests are passing.

apollo-cla · 2021-03-07T21:23:53Z

@vany0114: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

bennypowers · 2021-03-09T07:20:54Z

I'm implementing in my project with the following patch:

diff

diff --git a/node_modules/apollo-server-azure-functions/.DS_Store b/node_modules/apollo-server-azure-functions/.DS_Store
new file mode 100644
index 0000000..c88a062
Binary files /dev/null and b/node_modules/apollo-server-azure-functions/.DS_Store differ
diff --git a/node_modules/apollo-server-azure-functions/dist/ApolloServer.d.ts b/node_modules/apollo-server-azure-functions/dist/ApolloServer.d.ts
index f8712a4..783bbbf 100644
--- a/node_modules/apollo-server-azure-functions/dist/ApolloServer.d.ts
+++ b/node_modules/apollo-server-azure-functions/dist/ApolloServer.d.ts
@@ -1,5 +1,5 @@
 import { Context, HttpRequest } from '@azure/functions';
-import { ApolloServerBase } from 'apollo-server-core';
+import { ApolloServerBase, Config as ConfigBase } from 'apollo-server-core';
 import { GraphQLOptions } from 'apollo-server-core';
 export interface CreateHandlerOptions {
     cors?: {
@@ -11,8 +11,13 @@ export interface CreateHandlerOptions {
         maxAge?: number;
     };
 }
+export interface Config extends ConfigBase {
+  onHealthCheck?: (context: Context, request: HttpRequest) => Promise<any>;
+}
+
 export declare class ApolloServer extends ApolloServerBase {
     protected serverlessFramework(): boolean;
+    constructor(config: Config);
     createGraphQLServerOptions(request: HttpRequest, context: Context): Promise<GraphQLOptions>;
     createHandler({ cors }?: CreateHandlerOptions): (context: Context, req: HttpRequest) => void;
 }
diff --git a/node_modules/apollo-server-azure-functions/dist/ApolloServer.js b/node_modules/apollo-server-azure-functions/dist/ApolloServer.js
index e95c87a..ec4820c 100644
--- a/node_modules/apollo-server-azure-functions/dist/ApolloServer.js
+++ b/node_modules/apollo-server-azure-functions/dist/ApolloServer.js
@@ -10,6 +10,7 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ApolloServer = void 0;
+const { URL } = require('url');
 const apollo_server_core_1 = require("apollo-server-core");
 const graphql_playground_html_1 = require("@apollographql/graphql-playground-html");
 const azureFunctionApollo_1 = require("./azureFunctionApollo");
@@ -20,6 +21,10 @@ class ApolloServer extends apollo_server_core_1.ApolloServerBase {
     createGraphQLServerOptions(request, context) {
         return super.graphQLServerOptions({ request, context });
     }
+    constructor(config) {
+        super(config);
+        this.onHealthCheck = config && config.onHealthCheck;
+    }
     createHandler({ cors } = { cors: undefined }) {
         const promiseWillStart = this.willStart();
         const corsHeaders = {};
@@ -79,18 +84,55 @@ class ApolloServer extends apollo_server_core_1.ApolloServerBase {
                 });
                 return;
             }
-            if (this.playgroundOptions && req.method === 'GET') {
-                const acceptHeader = req.headers['Accept'] || req.headers['accept'];
-                if (acceptHeader && acceptHeader.includes('text/html')) {
-                    const path = req.url || '/';
-                    const playgroundRenderPageOptions = Object.assign({ endpoint: path }, this.playgroundOptions);
-                    const body = graphql_playground_html_1.renderPlaygroundPage(playgroundRenderPageOptions);
-                    context.done(null, {
-                        body: body,
-                        status: 200,
-                        headers: Object.assign({ 'Content-Type': 'text/html' }, corsHeaders),
-                    });
-                    return;
+            if (req.method === 'GET') {
+                const url = new URL(req.url);
+                if (url.pathname.endsWith('/.well-known/apollo/server-health')) {
+                    // Response follows https://tools.ietf.org/html/draft-inadarei-api-health-check-01
+                    if (typeof this.onHealthCheck === 'function') {
+                        this.onHealthCheck(context, req)
+                            .then(() => {
+                                context.done(null, {
+                                    body: JSON.stringify({ status: 'pass' }),
+                                    status: 200,
+                                    headers: {
+                                        'Content-Type': 'application/health+json'
+                                    }
+                                });
+                            })
+                            .catch(() => {
+                                context.done(null, {
+                                    body: JSON.stringify({ status: 'fail' }),
+                                    status: 503,
+                                    headers: {
+                                        'Content-Type': 'application/health+json'
+                                    }
+                                });
+                            });
+                        return;
+                    } else {
+                        context.done(null, {
+                            body: JSON.stringify({ status: 'pass' }),
+                            status: 200,
+                            headers: {
+                                'Content-Type': 'application/health+json'
+                            }
+                        });
+                        return;
+                    }
+                }
+                else if (this.playgroundOptions) {
+                    const acceptHeader = req.headers['Accept'] || req.headers['accept'];
+                    if (acceptHeader && acceptHeader.includes('text/html')) {
+                        const path = req.url || '/';
+                        const playgroundRenderPageOptions = Object.assign({ endpoint: path }, this.playgroundOptions);
+                        const body = graphql_playground_html_1.renderPlaygroundPage(playgroundRenderPageOptions);
+                        context.done(null, {
+                            body: body,
+                            status: 200,
+                            headers: Object.assign({ 'Content-Type': 'text/html' }, corsHeaders),
+                        });
+                        return;
+                    }
                 }
             }
             const callbackFilter = (error, output) => {
diff --git a/node_modules/apollo-server-azure-functions/src/ApolloServer.ts b/node_modules/apollo-server-azure-functions/src/ApolloServer.ts
index c0ee393..ceaea20 100644
--- a/node_modules/apollo-server-azure-functions/src/ApolloServer.ts
+++ b/node_modules/apollo-server-azure-functions/src/ApolloServer.ts
@@ -1,6 +1,7 @@
 import { Context, HttpRequest } from '@azure/functions';
 import { HttpResponse } from 'azure-functions-ts-essentials';
-import { ApolloServerBase } from 'apollo-server-core';
+import { ApolloServerBase, Config as ConfigBase } from 'apollo-server-core';
+import { URL } from 'url';
 import { GraphQLOptions } from 'apollo-server-core';
 import {
   renderPlaygroundPage,
@@ -20,11 +21,22 @@ export interface CreateHandlerOptions {
   };
 }
 
+export interface Config extends ConfigBase {
+  onHealthCheck?: (context: Context, request: HttpRequest) => Promise<any>;
+}
+
 export class ApolloServer extends ApolloServerBase {
   protected serverlessFramework(): boolean {
     return true;
   }
 
+  private onHealthCheck?: (context: Context, request: HttpRequest) => Promise<any>;
+
+  constructor(config: Config) {
+    super(config);
+    this.onHealthCheck = config && config.onHealthCheck;
+  }
+
   // This translates the arguments from the middleware into graphQL options It
   // provides typings for the integration specific behavior, ideally this would
   // be propagated with a generic to the super class
@@ -110,25 +122,61 @@ export class ApolloServer extends ApolloServerBase {
         return;
       }
 
-      if (this.playgroundOptions && req.method === 'GET') {
-        const acceptHeader = req.headers['Accept'] || req.headers['accept'];
-        if (acceptHeader && acceptHeader.includes('text/html')) {
-          const path = req.url || '/';
-
-          const playgroundRenderPageOptions: PlaygroundRenderPageOptions = {
-            endpoint: path,
-            ...this.playgroundOptions,
-          };
-          const body = renderPlaygroundPage(playgroundRenderPageOptions);
-          context.done(null, {
-            body: body,
-            status: 200,
-            headers: {
-              'Content-Type': 'text/html',
-              ...corsHeaders,
-            },
-          });
-          return;
+      if (req.method === 'GET') {
+        const url = new URL(req.url);
+        if (url.pathname.endsWith('/.well-known/apollo/server-health')) {
+          // Response follows https://tools.ietf.org/html/draft-inadarei-api-health-check-01
+          if (typeof this.onHealthCheck === 'function') {
+            this.onHealthCheck(context, req)
+              .then(() => {
+                context.done(null, {
+                  body: JSON.stringify({ status: 'pass' }),
+                  status: 200,
+                  headers: {
+                    'Content-Type': 'application/health+json'
+                  }
+                });
+              })
+              .catch(() => {
+                context.done(null, {
+                  body: JSON.stringify({ status: 'fail' }),
+                  status: 503,
+                  headers: {
+                    'Content-Type': 'application/health+json'
+                  }
+                });
+              });
+            return;
+          } else {
+            context.done(null, {
+              body: JSON.stringify({ status: 'pass' }),
+              status: 200,
+              headers: {
+                'Content-Type': 'application/health+json'
+              }
+            });
+            return;
+          }
+        } else if (this.playgroundOptions) {
+          const acceptHeader = req.headers['Accept'] || req.headers['accept'];
+          if (acceptHeader && acceptHeader.includes('text/html')) {
+            const path = req.url || '/';
+
+            const playgroundRenderPageOptions: PlaygroundRenderPageOptions = {
+              endpoint: path,
+              ...this.playgroundOptions,
+            };
+            const body = renderPlaygroundPage(playgroundRenderPageOptions);
+            context.done(null, {
+              body: body,
+              status: 200,
+              headers: {
+                'Content-Type': 'text/html',
+                ...corsHeaders,
+              },
+            });
+            return;
+          }
         }
       }

In order for this to work, I had to use the following function.json

{
  "disabled": false,
  "scriptFile": "../dist/server/graphql/index.js",
  "bindings": [
    {
      "authLevel": "anonymous",
      "type": "httpTrigger",
      "direction": "in",
      "name": "req",
      "route": "{*segments}",
      "methods": [
        "get",
        "post"
      ]
    },
    {
      "type": "http",
      "direction": "out",
      "name": "$return"
    }
  ]
}

glasser · 2021-03-25T22:08:50Z

@bennypowers Are you suggesting that your change is better than this PR? Should I be reviewing that as a PR instead of this one? Want to file a PR and explain the tradeoffs between yours and this one?

bennypowers · 2021-03-25T22:12:43Z

I can send over a pr some time in the next two weeks or so.

If OP is interested, they are welcome to implement here.

glasser · 2021-03-25T22:18:04Z

@bennypowers sure, I'm just curious, does your PR work better than this one for some reason? ie, should I avoid reviewing and merging this one?

bennypowers · 2021-03-25T22:28:02Z

OP has tests, which my patch lacks

But my patch has the right Content-Type header

In terms of impl details I can't say whether mine is any better than op's. I leave it to reviewers to make that judgement. If parts of my version are adopted in the final merged commit please consider using Co-Authored-By. If this pr is still in flight after Passover I can review OP's tests in light of my patch.

With either version, i'd also love to see a documentation commit with her necessary changes to function.json, as the az func won't work without it

vany0114 · 2021-03-25T22:38:57Z

@beardedtim Oh I see you're using the application/health+json header which makes total sense, I can change it in my PR. On the other hand, I think you're right regarding the function.json file (the "route": "{*segments}" setting) that should be present in the docs.

vany0114 · 2021-03-25T23:31:13Z

Done

glasser · 2021-04-06T21:45:10Z

Hi, I'm still not sure about what you're saying about the function.json change. Does there need to be an update to docs/source/deployment/azure-functions.md and/or packages/apollo-server-azure-functions/README.md to mention this function.json change?

Also, are you able to resolve conflicts?

vany0114 · 2021-04-07T03:42:33Z

@glasser I updated the docs as well as resolved the conflicts.

vany0114 · 2021-04-08T22:50:38Z

docs/source/deployment/azure-functions.md

@@ -112,6 +112,8 @@ It is important to set output binding name to **$return** to work correctly at t
 }
 ```

+**Note:** To enable the health checks it's necessary to [modify the route template](../../../packages/apollo-server-azure-functions/README.md#enabling-health-checks) in the `function.json` file.


@glasser it seems this broke the docs build, do you know how can I link it or should I just replicate the documentation here?

We don't put anything outside of docs in the docs site, so I'd recommend just linking to the README via a GitHub main branch or npmjs.com link. Replicating sounds good too though.

I'm hoping that as part of the AS3 push we can improve the integration/deployment docs to be more complete and authoritative.

@glasser done, all the checks are passing now!

vany0114 · 2021-05-07T00:58:04Z

@glasser any plans to merge this soon?

glasser · 2021-05-07T01:00:00Z

It's on my list of incoming PRs to review, but right now I'm heads down on getting Apollo Server 3 out the door.

abbeyciolek · 2021-09-20T22:35:51Z

@glasser are there any updates on this PR?

glasser · 2021-09-22T00:20:03Z

Sorry, there've been a bit of distractions lately (lots of late summer vacations etc) but it's on the queue still and I intend to get a lot of things on that queue done next week!

abbeyciolek · 2021-09-28T19:25:44Z

@glasser Thank you! Is this change still on track for this week?

glasser · 2021-10-01T18:12:30Z

This PR appears to still be based on top of Apollo Server 2. I'd be happy to review it (it does make sense to bring this integration to parity with other integrations) once it's rebased on top of current main.

vany0114 · 2021-10-03T00:08:56Z

@glasser I solved the conflicts. I also ran the prettier command however it still shows me an error that does not even make sense, any idea what I'm missing?

glasser · 2021-10-05T23:26:22Z

override is a new-ish feature of TypeScript so you probably haven't run npm install enough or something?

vany0114 · 2021-10-05T23:39:02Z

override is a new-ish feature of TypeScript so you probably haven't run npm install enough or something?

@glasser would you mind running the prettier --write for me? I'm having issues building locally.

glasser · 2021-10-05T23:41:30Z

Sure.

glasser · 2021-10-08T22:46:49Z

packages/apollo-server-azure-functions/src/ApolloServer.ts

+          if (req.url?.endsWith('/.well-known/apollo/server-health')) {
+            const successfulResponse = {
+              body: JSON.stringify({ status: 'pass' }),
+              statusCode: 200,


The existing code in this PR uses status, not statusCode. Do both actually work? Changing to status for consistency.

Change statusCode to status because that appears to be what Azure wants and what we do elsewhere. Make the apollo-server-azure-functions README mostly point to the docs site rather than be another thing that needs to be kept up to date (most other packages have this already).

vany0114 commented Apr 8, 2021

View reviewed changes

glasser added the 2021-09 label Sep 22, 2021

glasser removed the 2021-09 label Oct 1, 2021

glasser self-assigned this Oct 5, 2021

glasser added the 2021-10 label Oct 5, 2021

apollo-server-azure-functions: Health checks implementation

645bc2d

glasser force-pushed the vany0114/azfunctions-healthcheck branch from ee39b84 to 645bc2d Compare October 8, 2021 20:55

glasser reviewed Oct 8, 2021

View reviewed changes

glasser force-pushed the vany0114/azfunctions-healthcheck branch from da8aecc to 7e0eec0 Compare October 8, 2021 23:20

This was referenced May 17, 2022

Bump apollo-server from 3.1.2 to 3.4.1 in /graphql-server adamkeinan/auto-kube#78

Open

Bump apollo-datasource-rest from 0.14.0 to 3.6.0 lauriharpf/type-graphql-starter#127

Closed

This was referenced Jun 20, 2022

Bump apollo-server from 3.3.0 to 3.4.1 in /project-04/graphql-design glaucia86/graphql-ts-studies#12

Merged

Bump apollo-server from 3.1.1 to 3.4.1 Axe7bravo/hackernews-typescript#1

Open

This was referenced Jul 11, 2022

build(deps): bump apollo-server from 3.0.0 to 3.4.1 fredmoreira/phone-book-graphql#93

Merged

Bump apollo-server from 3.0.2 to 3.4.1 Prajwal264/toshokan-api#4

Merged

dependabot bot mentioned this pull request Sep 29, 2022

Bump apollo-server from 3.0.0 to 3.4.1 in /final/server CSalih/odyssey-lift-off#5

Closed

dependabot bot mentioned this pull request Oct 12, 2022

build(deps): bump apollo-server from 2.6.1 to 3.4.1 in /start/server zzsscc/apollographql-test#69

Open

trevor-scheer mentioned this pull request Oct 20, 2022

Support Health Checks for Azure functions package #4925

Closed

dependabot bot mentioned this pull request Mar 2, 2023

build(deps): bump apollo-reporting-protobuf from 3.3.3 to 3.4.0 nearform/mercurius-apollo-tracing#232

Merged

github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

apollo-server-azure-functions: Health checks implementation #5003

apollo-server-azure-functions: Health checks implementation #5003

vany0114 commented Mar 7, 2021

apollo-cla commented Mar 7, 2021

bennypowers commented Mar 9, 2021 •

edited

Loading

glasser commented Mar 25, 2021

bennypowers commented Mar 25, 2021

glasser commented Mar 25, 2021

bennypowers commented Mar 25, 2021

vany0114 commented Mar 25, 2021 •

edited

Loading

vany0114 commented Mar 25, 2021

glasser commented Apr 6, 2021

vany0114 commented Apr 7, 2021 •

edited

Loading

vany0114 Apr 8, 2021

glasser Apr 8, 2021

vany0114 Apr 9, 2021

vany0114 commented May 7, 2021

glasser commented May 7, 2021

abbeyciolek commented Sep 20, 2021

glasser commented Sep 22, 2021

abbeyciolek commented Sep 28, 2021

glasser commented Oct 1, 2021

vany0114 commented Oct 3, 2021

glasser commented Oct 5, 2021

vany0114 commented Oct 5, 2021

glasser commented Oct 5, 2021

glasser Oct 8, 2021

apollo-server-azure-functions: Health checks implementation #5003

apollo-server-azure-functions: Health checks implementation #5003

Conversation

vany0114 commented Mar 7, 2021

apollo-cla commented Mar 7, 2021

bennypowers commented Mar 9, 2021 • edited Loading

glasser commented Mar 25, 2021

bennypowers commented Mar 25, 2021

glasser commented Mar 25, 2021

bennypowers commented Mar 25, 2021

vany0114 commented Mar 25, 2021 • edited Loading

vany0114 commented Mar 25, 2021

glasser commented Apr 6, 2021

vany0114 commented Apr 7, 2021 • edited Loading

vany0114 Apr 8, 2021

Choose a reason for hiding this comment

glasser Apr 8, 2021

Choose a reason for hiding this comment

vany0114 Apr 9, 2021

Choose a reason for hiding this comment

vany0114 commented May 7, 2021

glasser commented May 7, 2021

abbeyciolek commented Sep 20, 2021

glasser commented Sep 22, 2021

abbeyciolek commented Sep 28, 2021

glasser commented Oct 1, 2021

vany0114 commented Oct 3, 2021

glasser commented Oct 5, 2021

vany0114 commented Oct 5, 2021

glasser commented Oct 5, 2021

glasser Oct 8, 2021

Choose a reason for hiding this comment

bennypowers commented Mar 9, 2021 •

edited

Loading

vany0114 commented Mar 25, 2021 •

edited

Loading

vany0114 commented Apr 7, 2021 •

edited

Loading