Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apollo-server-core: Update schema reporting plugin to support gateways #5187

Merged
merged 27 commits into from
Jul 22, 2021
Merged

apollo-server-core: Update schema reporting plugin to support gateways #5187

merged 27 commits into from
Jul 22, 2021

Commits on Jul 22, 2021

  1. Add optional onSchemaLoadOrUpdate method to GraphQLService, to be use… 

    …d for getting the core schema for gateways that have it (also clarify that onSchemaChange provides the API schema)
    @sachindshinde @glasser
    sachindshinde authored and glasser committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    4e10622 View commit details
    Browse the repository at this point in the history

  2. Add schemaDidLoadOrUpdate hook TS typings

    @sachindshinde @glasser
    sachindshinde authored and glasser committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    c89a9b9 View commit details
    Browse the repository at this point in the history

  3. Consolidate schema tracking logic (updates and notifications) into a … 

    …SchemaManager class for both gateway and non-gateway case, and implement schemaDidLoadOrUpdate handling
    @sachindshinde @glasser
    sachindshinde authored and glasser committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    31a3380 View commit details
    Browse the repository at this point in the history

  4. Update ApolloServerPluginSchemaReporting to use the new schemaDidLoad… 

    …OrUpdate hook to enable gateway schema reporting of the core schema
    @sachindshinde @glasser
    sachindshinde authored and glasser committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    3bc2da0 View commit details
    Browse the repository at this point in the history

  5. Remove "invoking serverWillStart" state, as it's no longer used.

    @sachindshinde @glasser
    sachindshinde authored and glasser committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    f0bdb18 View commit details
    Browse the repository at this point in the history

  6. Disable test that checks for gateway schema update unsubscribe for se… 

    …rverless
    @sachindshinde @glasser
    sachindshinde authored and glasser committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    4c714ae View commit details
    Browse the repository at this point in the history

  7. Use JS arrow function instead of JS bind()

    @sachindshinde @glasser
    sachindshinde authored and glasser committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    fe150cf View commit details
    Browse the repository at this point in the history

  8. Change TODO about gateway version message update into FIXME, and fix … 

    …bug in error message (the hook's name was wrong)
    @sachindshinde @glasser
    sachindshinde authored and glasser committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    530bb61 View commit details
    Browse the repository at this point in the history

  9. Throw a specific error subclass when the gateway is too old in Schema… 

    …Manager.onSchemaLoadOrUpdate() so that we can less-fragily try/catch
    @sachindshinde @glasser
    sachindshinde authored and glasser committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    f958c6b View commit details
    Browse the repository at this point in the history

  10. Accept overrideReportedSchema for schema reporting in gateways as the… 

    … core schema instead of throwing
    @sachindshinde @glasser
    sachindshinde authored and glasser committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    64e1467 View commit details
    Browse the repository at this point in the history

  11. Change schemaDidLoadOrUpdate() hook to early return after executing o… 

    …nce if the schema is overridden
    @sachindshinde @glasser
    sachindshinde authored and glasser committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    b7e4345 View commit details
    Browse the repository at this point in the history

  12. Remove loadedSchema from server state, as it's no longer used

    @sachindshinde @glasser
    sachindshinde authored and glasser committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    d3ca2af View commit details
    Browse the repository at this point in the history

  13. Update GatewayInterface.onSchemaChange to be optional, in preparation… 

    … for it eventually being removed
    @sachindshinde @glasser
    sachindshinde authored and glasser committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    4921428 View commit details
    Browse the repository at this point in the history

  14. Re-enable test on serverless that checks whether gateway unsubscribe … 

    …is called after stop using a workaround
    @sachindshinde @glasser
    sachindshinde authored and glasser committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    2e57079 View commit details
    Browse the repository at this point in the history

  15. Throw when SchemaManager.onSchemaLoadOrUpdate() is called before Sche… 

    …maManager.start()
    @sachindshinde @glasser
    sachindshinde authored and glasser committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    8e4e86a View commit details
    Browse the repository at this point in the history

  16. Add FIXME to update error message in SchemaManager.onSchemaLoadOrUpda… 

    …te() to include needed gateway version
    @sachindshinde @glasser
    sachindshinde authored and glasser committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    5c3a1f0 View commit details
    Browse the repository at this point in the history

  17. Keep stacktrace info when logging errors in SchemaManager.processSche… 

    …maLoadOrUpdateEvent()
    @sachindshinde @glasser
    sachindshinde authored and glasser committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    1ff88b8 View commit details
    Browse the repository at this point in the history

  18. Change SchemaManager.onSchemaLoadOrUpdate() to log and throw if a cal… 

    …lback throws
    @sachindshinde @glasser
    sachindshinde authored and glasser committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    0e3249b View commit details
    Browse the repository at this point in the history

  19. Update docs for plugins and migration

    @sachindshinde @glasser
    sachindshinde authored and glasser committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    2535449 View commit details
    Browse the repository at this point in the history

  20. Update CHANGELOG.md

    @sachindshinde @glasser
    sachindshinde authored and glasser committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    95deff6 View commit details
    Browse the repository at this point in the history

  21. Clarify docs for schemaDidLoadOrUpdate to note that not providing a… 

    … gateway won't result in failure
    @sachindshinde @glasser
    sachindshinde authored and glasser committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    0ac2944 View commit details
    Browse the repository at this point in the history

  22. Refactor some if/elses around the APOLLO_SCHEMA_REPORTING env var

    @sachindshinde @glasser
    sachindshinde authored and glasser committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    bb8b6d2 View commit details
    Browse the repository at this point in the history

  23. Add warning to ApolloServerBase.stop() to indicate that it may not be… 

    … called concurrently with start() (or before start()).
    @sachindshinde @glasser
    sachindshinde authored and glasser committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    4681a98 View commit details
    Browse the repository at this point in the history

  24. Remove logging around callback errors in SchemaManager.onSchemaLoadOr… 

    …Update()
    @sachindshinde @glasser
    sachindshinde authored and glasser committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    341af1f View commit details
    Browse the repository at this point in the history

  25. Update CHANGELOG.md to state that schema reporting shouldn't be enabl… 

    …e for gateways yet, because Apollo Studio does not support it.
    @sachindshinde @glasser
    sachindshinde authored and glasser committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    a498b4a View commit details
    Browse the repository at this point in the history

  26. CHANGELOG: tweak wording, move up to vNEXT

    @glasser
    glasser committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    f5241eb View commit details
    Browse the repository at this point in the history

  27. Update version numbers from FIXMEs

    @glasser
    glasser committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    19ce0f8 View commit details
    Browse the repository at this point in the history