apollo-server-fastify: drop dependency on fast-json-stringify
#5988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glasser
force-pushed
the
glasser/even-faster-json-stringify
branch
from
a735efa
to
4746a42
Compare
This package was being used only to stringify two small constant objects. It has a major version update available and rather than evaluate the CHANGELOG, we might as well just not use it. (Honestly I think it would be fine to just use JSON.stringify here; I don't see any justification in #1971 for why this particular use case requires a faster stringification than all the other JSON stringification we do in Apollo Server. But just in case this matters to anybody, I went with the fastest possible way of converting a constant object to string.) This should replace #5985.
glasser
force-pushed
the
glasser/even-faster-json-stringify
branch
from
4746a42
to
1ffe0c5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package was being used only to stringify two small constant
objects. It has a major version update available and rather than
evaluate the CHANGELOG, we might as well just not use it.
(Honestly I think it would be fine to just use JSON.stringify here; I
don't see any justification in #1971 for why this particular use case
requires a faster stringification than all the other JSON
stringification we do in Apollo Server. But just in case this matters to
anybody, I went with the fastest possible way of converting a constant
object to string.)
This should replace #5985.