Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requestPipeline: clean up some casts around error types #6679

Merged
merged 1 commit into from Jul 13, 2022

Conversation

glasser
Copy link
Member

@glasser glasser commented Jul 13, 2022

We now ensure various thrown things are Errors or GraphQLErrors as
appropriate.

@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2022

⚠️ No Changeset found

Latest commit: 7af859e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jul 13, 2022

Deploy Preview for apollo-server-docs failed.

Name Link
🔨 Latest commit 7af859e
🔍 Latest deploy log https://app.netlify.com/sites/apollo-server-docs/deploys/62cf3bb58d27480009f73168

@glasser glasser force-pushed the glasser/error-types-request-pipeline-v4 branch from b7fcd19 to 33a922d Compare July 13, 2022 21:32
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 13, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7af859e:

Sandbox Source
Apollo Server Typescript Configuration
Apollo Server Configuration

We now ensure various thrown things are Errors or GraphQLErrors as
appropriate.
@glasser glasser force-pushed the glasser/error-types-request-pipeline-v4 branch from 33a922d to 7af859e Compare July 13, 2022 21:40
@glasser glasser enabled auto-merge (squash) July 13, 2022 21:40
@glasser glasser disabled auto-merge July 13, 2022 21:41
@glasser glasser merged commit ff9ae17 into version-4 Jul 13, 2022
@glasser glasser deleted the glasser/error-types-request-pipeline-v4 branch July 13, 2022 21:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants