Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usage reporting: fix memory leak #6998

Merged
merged 1 commit into from Oct 7, 2022

Commits on Oct 7, 2022

  1. usage reporting: fix memory leak

    A data structure in the usage reporting plugin would get a new entry
    each time the server's schema changed. Old entries would never be
    deleted, though their values would be shrunk to a minimum size.
    
    It seems that this was not good enough and is producing notable memory
    leaks for some folks. So let's fix it!
    
    The reason for the old behavior was to be really careful to never write
    to a report that may have already been taken out of the map and sent.
    Previously this was accomplished by having the main entry in the map
    never change. Now this is accomplished by making sure that we never
    write to the report any later than immediately (and synchronously) after
    we pull it out of the map.
    
    Fixes #6983.
    glasser committed Oct 7, 2022
    Copy the full SHA
    49c82aa View commit details
    Browse the repository at this point in the history