New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand on non-nullability of _Service.sdl
field
#7301
Conversation
Fed v2 updated the subgraph spec to make _Service.sdl non-nullable. We should explain this thoroughly in our docs, test for both cases, and update a relevant recent changelog entry. Follow-up to #7274.
✅ Deploy Preview for apollo-server-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8f4b920:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I've only added a minor nit, which might not be that useful :)
Thanks so much 😊
Fed v2 updated the subgraph spec to make
_Service.sdl
non-nullable. We should explain this thoroughly in our docs, test for both cases, and update a relevant recent changelog entry. Follow-up to #7274.Addresses #7274 (comment)