Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Introduce status code regression mitigation #7465

Merged
merged 12 commits into from
Mar 27, 2023
Merged

fix: Introduce status code regression mitigation #7465

merged 12 commits into from
Mar 27, 2023

Commits on Mar 23, 2023

  1. Introduce status code regression mitigation 

    Apollo Server v4 introduced a regression with respect to invalid
`variables` and http status codes. AS4 incorrectly started responding
with a 200 status code, where AS3 would respond with a 400.

Providing the following config to your AS4 constructor options will
opt-in to the regression mitigation:
```
new ApolloServer({
  // ...
  status400WithErrorsAndNoData: true,
})
```
    @trevor-scheer
    trevor-scheer committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    67aa89f View commit details
    Browse the repository at this point in the history

  2. prettier and FIXME

    @trevor-scheer
    trevor-scheer committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    dc193cf View commit details
    Browse the repository at this point in the history

  3. fix broken docs deploy?

    @trevor-scheer
    trevor-scheer committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    74e8a7b View commit details
    Browse the repository at this point in the history

  4. oops

    @trevor-scheer
    trevor-scheer committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    d206d50 View commit details
    Browse the repository at this point in the history

  5. add api entry

    @trevor-scheer
    trevor-scheer committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    4a27114 View commit details
    Browse the repository at this point in the history

  6. Update docs/source/api/apollo-server.mdx 

    Co-authored-by: Stephen Barlow <stephen@apollographql.com>
    @trevor-scheer
    trevor-scheer and Stephen Barlow committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    cc7636c View commit details
    Browse the repository at this point in the history

  7. Update docs/source/data/errors.mdx 

    Co-authored-by: Stephen Barlow <stephen@apollographql.com>
    @trevor-scheer
    trevor-scheer and Stephen Barlow committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    775502e View commit details
    Browse the repository at this point in the history

  8. Apply suggestions from code review 

    Co-authored-by: Stephen Barlow <stephen@apollographql.com>
    @trevor-scheer
    trevor-scheer and Stephen Barlow committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    28283d7 View commit details
    Browse the repository at this point in the history

  9. reintroduce multicodeblocks

    @trevor-scheer
    trevor-scheer committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    dba9316 View commit details
    Browse the repository at this point in the history

  10. test circle auth

    @trevor-scheer
    trevor-scheer committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    fc1ce84 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2023

  1. address feedback

    @trevor-scheer
    trevor-scheer committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    c8cff44 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: David Glasser <glasser@apollographql.com>
    @trevor-scheer @glasser
    trevor-scheer and glasser committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    4fa3401 View commit details
    Browse the repository at this point in the history