Landing Pages: switch from _latest to v* cdn buckets to pin major versions of landing pages
#7741
Conversation
…inned buckets for Embeddable Sandbox & Explorer
✅ Deploy Preview for apollo-server-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e2c4c75:
|
| const explorerVersion = maybeVersion ?? 'v3'; | ||
| const sandboxVersion = maybeVersion ?? 'v2'; | ||
| const apolloServerLandingPageVersion = maybeVersion ?? '_latest'; |
There was a problem hiding this comment.
Can we export these defaults and import them in the test? It'll be nice to see test updates tied to the constants updating.
There was a problem hiding this comment.
oops missed this, doing now
|
Looks like this integration test needs an update |
trevor-scheer
changed the title
_latest to v* cdn buckets to pin major versions of landing pages
|
Just a note for anyone gathering context from this PR. All current AS4 versions at the time of writing this comment are affected by this. New major versions of the landing pages should not be published to the |
packages/server/src/__tests__/plugin/landingPage/getEmbeddedExplorerHTML.test.ts
Outdated
Show resolved
Hide resolved
packages/server/src/__tests__/plugin/landingPage/getEmbeddedSandboxHTML.test.ts
Outdated
Show resolved
Hide resolved
| * By default, the landing page plugin uses the version of the landing | ||
| * page published to Apollo's CDN from https://github.com/apollographql/embeddable-explorer/commit/73baf89f5308d263425bbafe21a842a26123cfac. | ||
| * If you'd like to pin the current version, pass the SHA served at | ||
| * https://apollo-server-landing-page.cdn.apollographql.com/latest/version.txt |
There was a problem hiding this comment.
I'm not sure that putting a specific commit is accurate over time here. Can we simplify this comment a bit? Something like this or maybe just a bulleted list of what's acceptable here.
Specify the major version of the landing page to use, i.e
v2or provide a specific commit from the embeddable explorer repo. We also support alatesttag but don't recommend using it as it's subject to major version updates.
…plorerHTML.test.ts Co-authored-by: Trevor Scheer <trevor.scheer@gmail.com>
…ndboxHTML.test.ts Co-authored-by: Trevor Scheer <trevor.scheer@gmail.com>
|
@trevor-scheer comment updates, is that all we needed here? |
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @apollo/server-integration-testsuite@4.9.5 ### Patch Changes - [#7717](#7717) [`681bdd0dc`](681bdd0) Thanks [@renovate](https://github.com/apps/renovate)! - Update graphql-http dependency - Updated dependencies \[[`07585fe39`](07585fe), [`4fac1628c`](4fac162)]: - @apollo/server@4.9.5 ## @apollo/server@4.9.5 ### Patch Changes - [#7741](#7741) [`07585fe39`](07585fe) Thanks [@mayakoneval](https://github.com/mayakoneval)! - Pin major releases of embeddable Explorer & Sandbox code. - [#7769](#7769) [`4fac1628c`](4fac162) Thanks [@cwikla](https://github.com/cwikla)! - Change SchemaReporter.pollTimer from being a NodeJS.Timer to a NodeJS.Timeout Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
I published these buckets once already. Circle CI changes here
in AS5 we want to pin embeddable code versions. Question - should we pin up to patch decimal, not just major? Just in case?