Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to subscription callback protocol GA #7793

Merged
merged 16 commits into from
Dec 18, 2023
Merged

upgrade to subscription callback protocol GA #7793

merged 16 commits into from
Dec 18, 2023

Commits on Nov 29, 2023

  1. upgrade to subscription callback protocol GA 

    Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
    @bnjjj
    bnjjj committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    937e096 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. fix tests 

    Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
    @bnjjj
    bnjjj committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    c3c584f View commit details
    Browse the repository at this point in the history

  2. add more tests 

    Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
    @bnjjj
    bnjjj committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    81540a7 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. get rid of subscriptionsById 

    Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
    @bnjjj
    bnjjj committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    2abb6a7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:apollographql/apollo-server into bn… 

    …jjj/update_callback_plugin
    @bnjjj
    bnjjj committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    7e04082 View commit details
    Browse the repository at this point in the history

  3. add changeset 

    Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
    @bnjjj
    bnjjj committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    9d69367 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Trevor Scheer <trevor.scheer@gmail.com>
    @bnjjj @trevor-scheer
    bnjjj and trevor-scheer committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    dd5d680 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. review 

    Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
    @bnjjj
    bnjjj committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    c06d93a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'bnjjj/update_callback_plugin' of github.com:apollograph… 

    …ql/apollo-server into bnjjj/update_callback_plugin
    @bnjjj
    bnjjj committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    90d3277 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. fix tests 

    Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
    @bnjjj
    bnjjj committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    acb69f7 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Use executeHTTPGraphQLRequest in subscription tests 

    The callback protocol requires specific accept/content-type
headers as well as a subscription-protocol header in its
requests/responses between router and server. In order to
test the correct behavior here, we need to include the HTTP
layer in the testing details of the callback plugin.
    @trevor-scheer
    trevor-scheer committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    50722af View commit details
    Browse the repository at this point in the history

  2. Apply and test for special headers appropriately 

    The subscription-protocol header should be sent for `check` requests
The content-type: application/json+graphql+callback/1.0 is only necessary
in response to the original subscription request.
    @trevor-scheer
    trevor-scheer committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    b4839f0 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. for tests purposes 

    Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
    @bnjjj
    bnjjj committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    7e04f1c View commit details
    Browse the repository at this point in the history

  2. change accept header and content-type 

    Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
    @bnjjj
    bnjjj committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    8d57450 View commit details
    Browse the repository at this point in the history

  3. handle callback subscriptions properly when heartbeat is disabled 

    Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
    @bnjjj
    bnjjj committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    83369e3 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. refactor 

    Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
    @bnjjj
    bnjjj committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    ee56889 View commit details
    Browse the repository at this point in the history