Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: return PersistedQueryNotSupported for Apollo Persisted Queries #982

Merged
merged 1 commit into from
Apr 24, 2018

Commits on Apr 23, 2018

  1. core: return PersistedQueryNotSupported for Apollo Persisted Queries

    Apollo Persisted Queries is a standard for sending queries as short hashes
    instead of full strings, designed to work well with GET requests. It is
    implemented by servers including the Apollo Engine Proxy, and by the
    apollo-link-persisted-query client.
    
    A common configuration is to set up persisted queries on production servers but
    not in development. It is still convenient to leave apollo-link-persisted-query
    always on, though. While apollo-link-persisted-query can detect that servers
    don't support PQs, it works better if the server actually says it doesn't
    support the PQ, instead of trying to process a request without a query and
    potentially printing a confusing stack trace.  This commit makes apollo-server
    directly return PersistedQueryNotSupported instead of allowing confusing stack
    traces to occur.
    glasser committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    8f4f0c4 View commit details
    Browse the repository at this point in the history