Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable logging when codegen is in watch mode and detects changes #1039

Merged
merged 2 commits into from
Feb 25, 2019
Merged

Re-enable logging when codegen is in watch mode and detects changes #1039

merged 2 commits into from
Feb 25, 2019

Conversation

JakeDawkins
Copy link
Contributor

@JakeDawkins JakeDawkins commented Feb 21, 2019 •
edited

Resolves #603

At some point the console log was disabled telling users that types had been updated from codegen in watch mode. This PR is just re-enabling that :)

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@JakeDawkins JakeDawkins merged commit b8a26ab into master Feb 25, 2019
@JakeDawkins JakeDawkins deleted the jake/log-codegen-output branch February 25, 2019 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbaxleyiii jbaxleyiii jbaxleyiii approved these changes

@trevor-scheer trevor-scheer Awaiting requested review from trevor-scheer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JakeDawkins @jbaxleyiii