Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable logging when codegen is in watch mode and detects changes #1039

Merged
merged 2 commits into from
Feb 25, 2019
Merged

Re-enable logging when codegen is in watch mode and detects changes #1039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6754d3
Re-enable logging when codegen is in watch mode and detects changes
JakeDawkins Feb 21, 2019
59f31dd
update changelog
JakeDawkins Feb 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
# Changelog

## Upcoming
- Fix a bug where tagging a build will cause the tool to not be able to figure out where the git repo is [#944](https://github.com/apollographql/apollo-tooling/pull/944)

- `apollo`
- Fix a bug where tagging a build will cause the tool to not be able to figure out where the git repo is [#944](https://github.com/apollographql/apollo-tooling/pull/944)
- Re-enable logging for codegen when in watch mode [#1039](https://github.com/apollographql/apollo-tooling/pull/1039)
- `apollo-language-server`
- Added a warning when there are 0 files found in a project [#1007](https://github.com/apollographql/apollo-tooling/pull/1007)
- Allow relative paths in includes/excludes globs [#1007](https://github.com/apollographql/apollo-tooling/pull/1007)
Expand Down
2 changes: 1 addition & 1 deletion packages/apollo/src/commands/client/codegen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ export default class Generate extends ClientCommand {
await run().catch(() => {});
const watcher = new Gaze(this.project.config.client.includes);
watcher.on("all", (event, file) => {
// console.log("\nChange detected, generating types...");
console.log("\nChange detected, generating types...");
this.project.fileDidChange(URI.file(file).toString());
});
if (tty.isatty((process.stdin as any).fd)) {
Expand Down