Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[language server/vscode] Add Ruby support #1304

Merged
merged 2 commits into from Jul 12, 2019

Conversation

alloy
Copy link
Contributor

@alloy alloy commented May 29, 2019

As the title says, this adds support for Ruby projects that use <<-GRAPHQL…GRAPHQL heredoc strings to define GraphQL documents.

An example can be found here https://github.com/artsy/exchange/pull/413

Screenshot 2019-05-29 at 14 05 32

@alloy alloy force-pushed the add-ruby-support branch 2 times, most recently from 5f82fac to a4104de Compare June 4, 2019 13:50
@alloy
Copy link
Contributor Author

alloy commented Jun 4, 2019

@trevor-scheer This is rebased against current master.

@alloy
Copy link
Contributor Author

alloy commented Jun 18, 2019

Bump

@trevor-scheer trevor-scheer merged commit 0e44594 into apollographql:master Jul 12, 2019
@alloy alloy deleted the add-ruby-support branch July 17, 2019 18:04
@alloy
Copy link
Contributor Author

alloy commented Jul 17, 2019

Thanks! 🙌

@trevor-scheer
Copy link
Member

@alloy this change is now live on the marketplace extension v1.8.1. Thanks again for the contribution! 🎉 ❤️

@alloy
Copy link
Contributor Author

alloy commented Jul 23, 2019

Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants