Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate Swift operation IDs and operation <--> operation ID mapping file #147

Merged
merged 19 commits into from
Jun 29, 2017
Merged

Generate Swift operation IDs and operation <--> operation ID mapping file #147

merged 19 commits into from
Jun 29, 2017

Commits on Jun 28, 2017

  1. Initial progress on Swift operationId generation

    Paul Kompfner committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    8299bc6 View commit details
    Browse the repository at this point in the history

  2. Add dependency on crypto library for SHA256

    Paul Kompfner committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    82f7d4e View commit details
    Browse the repository at this point in the history

  3. In Swift, operationId is computed and output with every operation class

    Paul Kompfner committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    748dc76 View commit details
    Browse the repository at this point in the history

  4. Factor out Swift operationId into its own function

    Paul Kompfner committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    4311cba View commit details
    Browse the repository at this point in the history

  5. Write to a JSON file the mapping between operations and their ids (Sw… 

    …ift-only)
    Paul Kompfner committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    0900ded View commit details
    Browse the repository at this point in the history

  6. Update operationIds map to be keyed by operation name (which are guar… 

    …anteed by apollo-codegen to be unique) and providing values with both operation id and source
    Paul Kompfner committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    e122026 View commit details
    Browse the repository at this point in the history

  7. OperationIds map is keyed by id, and operation name is part of the value

    Paul Kompfner committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    3fde719 View commit details
    Browse the repository at this point in the history

  8. Use === instead of ==

    Paul Kompfner committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    e083bb6 View commit details
    Browse the repository at this point in the history

  9. Update Swift Jest snapshots with new newline

    Paul Kompfner committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    eb01d92 View commit details
    Browse the repository at this point in the history

  10. Fix missing comma

    Paul Kompfner committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    4c8619e View commit details
    Browse the repository at this point in the history

  11. Add fragments to classDeclarationForOperation invocation in Swift tests

    Paul Kompfner committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    881eccd View commit details
    Browse the repository at this point in the history

  12. Add unit tests exercising operation id generation in Swift

    Paul Kompfner committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    728c3d3 View commit details
    Browse the repository at this point in the history

  13. Move generation of operation IDs and operation source + fragments to … 

    …compilation step rather than code generation step.

Also, when generating operation source + fragments, handle possibility of nested fragment references.
    Paul Kompfner committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    bcbf180 View commit details
    Browse the repository at this point in the history

  14. Remove obsolete test checking for generated mapping between operation… 

    … ids and sources on context (it's no longer done that way)
    Paul Kompfner committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    a9480b2 View commit details
    Browse the repository at this point in the history

  15. Improve readability of generateOperationIds option in compileFromSour… 

    …ce function in Swif tests
    Paul Kompfner committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    9b1934f View commit details
    Browse the repository at this point in the history

  16. Add Swift code generation test that verifies that, when there are nes… 

    …ted fragment refrences, the correct source + fragments is generated for the operation id mapping file
    Paul Kompfner committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    562297d View commit details
    Browse the repository at this point in the history

  17. Fix typescript error related to operation ids map

    Paul Kompfner committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    c6f5447 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2017

  1. PR feedback and tweaks: 

    - Improve CLI message
- Remove unnecessary parameter in a function call
- Rename Swift operationId to operationIdentifier
    Paul Kompfner committed Jun 29, 2017
    Configuration menu
    Copy the full SHA
    ca36307 View commit details
    Browse the repository at this point in the history

  2. Update test snapshot

    Paul Kompfner committed Jun 29, 2017
    Configuration menu
    Copy the full SHA
    1f307e6 View commit details
    Browse the repository at this point in the history