-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate Swift operation IDs and operation <--> operation ID mapping file #147
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
8299bc6
Initial progress on Swift operationId generation
82f7d4e
Add dependency on crypto library for SHA256
748dc76
In Swift, operationId is computed and output with every operation class
4311cba
Factor out Swift operationId into its own function
0900ded
Write to a JSON file the mapping between operations and their ids (Sw…
e122026
Update operationIds map to be keyed by operation name (which are guar…
3fde719
OperationIds map is keyed by id, and operation name is part of the value
e083bb6
Use === instead of ==
eb01d92
Update Swift Jest snapshots with new newline
4c8619e
Fix missing comma
881eccd
Add fragments to classDeclarationForOperation invocation in Swift tests
728c3d3
Add unit tests exercising operation id generation in Swift
bcbf180
Move generation of operation IDs and operation source + fragments to …
a9480b2
Remove obsolete test checking for generated mapping between operation…
9b1934f
Improve readability of generateOperationIds option in compileFromSour…
562297d
Add Swift code generation test that verifies that, when there are nes…
c6f5447
Fix typescript error related to operation ids map
ca36307
PR feedback and tweaks:
1f307e6
Update test snapshot
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be a separate option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think having this as a separate option reads a lot better, especially in
codeGeneration.js
, which doesn't need to know or care about file paths.