Use reference-equality when filtering rules in buildSchemaFromSDL

[abernix]

Similar in spirit to apollographql/apollo-server#3338.

The technique previously used for removing rules from the standard specifiedRules was leveraging a check on Function.prototype.name, rather than doing direct object equality. While that does generally work, thanks to the more recent standardization of Function.prototype.name, it still breaks down under some of the more aggressive minification techniques since a function's name is not guaranteed to remain the same.

Fixes: apollographql/apollo-server#3335

[abernix]

@trevor-scheer Should I manually add an entry to the root CHANGELOG.md? Done.

[glasser]

This change broke the ability to use apollo in engine-frontend, because it seems like PossibleTypeExtensions was added in graphql-js 14.1 and we were still on 14.0.

I recognize that the peer dep from apollo-graphql has been 14.2.1 since June, but it looks like 14.0 worked before; I just want to make sure you're aware that the requirement is now more strict than it was before.

[trevor-scheer]

@glasser thank you for pointing this out. Is this an issue that engine-frontend is currently dealing with, or were they able to upgrade / work around this?

So I understand correctly, is it accurate to say that engine-frontend has been ignoring an unmet peer dependency for some time based on their graphql version being too low?

[glasser]

I believe so.